Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: src/compiler/bytecode-graph-builder.cc

Issue 2531683004: [TurboFan] Always enable deoptimization for BytecodeGraphBuilder. (Closed)
Patch Set: Add DCHECK to bytecode graph builder Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/pipeline.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/bytecode-graph-builder.cc
diff --git a/src/compiler/bytecode-graph-builder.cc b/src/compiler/bytecode-graph-builder.cc
index 586b68ccbb1929f21b792fdc7174454d4717877e..80bf950940833a1f4a8c4f6348082e459dcef38a 100644
--- a/src/compiler/bytecode-graph-builder.cc
+++ b/src/compiler/bytecode-graph-builder.cc
@@ -503,14 +503,16 @@ BytecodeGraphBuilder::BytecodeGraphBuilder(
input_buffer_size_(0),
input_buffer_(nullptr),
exit_controls_(local_zone),
- is_liveness_analysis_enabled_(FLAG_analyze_environment_liveness &&
- info->is_deoptimization_enabled()),
+ is_liveness_analysis_enabled_(FLAG_analyze_environment_liveness),
state_values_cache_(jsgraph),
liveness_analyzer_(
static_cast<size_t>(bytecode_array()->register_count()), true,
local_zone),
source_positions_(source_positions),
- start_position_(info->shared_info()->start_position(), inlining_id) {}
+ start_position_(info->shared_info()->start_position(), inlining_id) {
+ // Bytecode graph builder assumes deoptimziation is enabled.
+ DCHECK(info->is_deoptimization_enabled());
+}
Node* BytecodeGraphBuilder::GetNewTarget() {
if (!new_target_.is_set()) {
« no previous file with comments | « no previous file | src/compiler/pipeline.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698