Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2531683004: [TurboFan] Always enable deoptimization for BytecodeGraphBuilder. (Closed)

Created:
4 years ago by rmcilroy
Modified:
4 years ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[TurboFan] Always enable deoptimization for BytecodeGraphBuilder. The BytecodeGraphBuilder assumes that deoptimization is always enabled, so always enable it when compiling from bytecode. BUG=chromium:668654 Committed: https://crrev.com/195754cf31a6f6d53a2fdf0dc41e67b69f7fbf8f Cr-Commit-Position: refs/heads/master@{#41303}

Patch Set 1 #

Patch Set 2 : Add DCHECK to bytecode graph builder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
rmcilroy
bmeurer/jarin PTAL. I've described the issue in more detail in crbug.com/668654. Let me know what ...
4 years ago (2016-11-25 15:37:26 UTC) #2
Benedikt Meurer
As mentioned on the bug: I like this a lot! I can't wait to make ...
4 years ago (2016-11-25 18:36:46 UTC) #7
Jarin
Awesome. lgtm.
4 years ago (2016-11-25 19:53:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2531683004/20001
4 years ago (2016-11-28 10:02:43 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-28 10:29:23 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-28 10:29:58 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/195754cf31a6f6d53a2fdf0dc41e67b69f7fbf8f
Cr-Commit-Position: refs/heads/master@{#41303}

Powered by Google App Engine
This is Rietveld 408576698