Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3355)

Unified Diff: base/task_scheduler/task_tracker.cc

Issue 2531663003: TaskScheduler: Add TaskTraits::WithWait(). (Closed)
Patch Set: CR danakj #22 (AssertWaitAllowed) Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/task_tracker.cc
diff --git a/base/task_scheduler/task_tracker.cc b/base/task_scheduler/task_tracker.cc
index d06a84dc1f47dd7a4cb16f4463a4fa0c486a6dca..03f161e0d1c25f1de5c76f897d0f0e1709801bd3 100644
--- a/base/task_scheduler/task_tracker.cc
+++ b/base/task_scheduler/task_tracker.cc
@@ -226,6 +226,9 @@ bool TaskTracker::RunTask(std::unique_ptr<Task> task,
task->traits.shutdown_behavior() !=
TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN);
+ const bool previous_wait_allowed =
+ ThreadRestrictions::SetWaitAllowed(task->traits.with_wait());
+
{
// Set up SequenceToken as expected for the scope of the task.
ScopedSetSequenceTokenForCurrentThread
@@ -261,6 +264,8 @@ bool TaskTracker::RunTask(std::unique_ptr<Task> task,
PerformRunTask(std::move(task));
}
+ ThreadRestrictions::SetWaitAllowed(previous_wait_allowed);
+
AfterRunTask(shutdown_behavior);
}
« no previous file with comments | « base/task_scheduler/scheduler_worker_pool_impl_unittest.cc ('k') | base/task_scheduler/task_tracker_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698