Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: base/task_scheduler/scheduler_worker_pool_impl_unittest.cc

Issue 2531663003: TaskScheduler: Add TaskTraits::WithWait(). (Closed)
Patch Set: CR danakj #22 (AssertWaitAllowed) Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/task_scheduler/task_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/task_scheduler/scheduler_worker_pool_impl_unittest.cc
diff --git a/base/task_scheduler/scheduler_worker_pool_impl_unittest.cc b/base/task_scheduler/scheduler_worker_pool_impl_unittest.cc
index 9983cad5c166bb1f11ff5e79d7a1c0802482812c..4af472883f9a3fec08cc608e04a6f9ffe0d5cc43 100644
--- a/base/task_scheduler/scheduler_worker_pool_impl_unittest.cc
+++ b/base/task_scheduler/scheduler_worker_pool_impl_unittest.cc
@@ -115,13 +115,15 @@ class TaskSchedulerWorkerPoolImplTest
scoped_refptr<TaskRunner> CreateTaskRunnerWithExecutionMode(
SchedulerWorkerPoolImpl* worker_pool,
test::ExecutionMode execution_mode) {
+ // Allow tasks posted to the returned TaskRunner to wait on a WaitableEvent.
+ const TaskTraits traits = TaskTraits().WithWait();
switch (execution_mode) {
case test::ExecutionMode::PARALLEL:
- return worker_pool->CreateTaskRunnerWithTraits(TaskTraits());
+ return worker_pool->CreateTaskRunnerWithTraits(traits);
case test::ExecutionMode::SEQUENCED:
- return worker_pool->CreateSequencedTaskRunnerWithTraits(TaskTraits());
+ return worker_pool->CreateSequencedTaskRunnerWithTraits(traits);
case test::ExecutionMode::SINGLE_THREADED:
- return worker_pool->CreateSingleThreadTaskRunnerWithTraits(TaskTraits());
+ return worker_pool->CreateSingleThreadTaskRunnerWithTraits(traits);
}
ADD_FAILURE() << "Unknown ExecutionMode";
return nullptr;
@@ -603,7 +605,7 @@ TEST_F(TaskSchedulerWorkerPoolCheckTlsReuse, CheckDetachedThreads) {
std::vector<std::unique_ptr<test::TestTaskFactory>> factories;
for (size_t i = 0; i < kNumWorkersInWorkerPool; ++i) {
factories.push_back(MakeUnique<test::TestTaskFactory>(
- worker_pool_->CreateTaskRunnerWithTraits(TaskTraits()),
+ worker_pool_->CreateTaskRunnerWithTraits(TaskTraits().WithWait()),
test::ExecutionMode::PARALLEL));
ASSERT_TRUE(factories.back()->PostTask(
PostNestedTask::NO,
@@ -674,8 +676,8 @@ TEST_F(TaskSchedulerWorkerPoolHistogramTest, NumTasksBetweenWaits) {
WaitableEvent event(WaitableEvent::ResetPolicy::MANUAL,
WaitableEvent::InitialState::NOT_SIGNALED);
InitializeWorkerPool(TimeDelta::Max(), kNumWorkersInWorkerPool);
- auto task_runner =
- worker_pool_->CreateSequencedTaskRunnerWithTraits(TaskTraits());
+ auto task_runner = worker_pool_->CreateSequencedTaskRunnerWithTraits(
+ TaskTraits().WithWait());
// Post a task.
task_runner->PostTask(FROM_HERE,
@@ -718,7 +720,8 @@ TEST_F(TaskSchedulerWorkerPoolHistogramTest, NumTasksBetweenWaitsWithDetach) {
WaitableEvent tasks_can_exit_event(WaitableEvent::ResetPolicy::MANUAL,
WaitableEvent::InitialState::NOT_SIGNALED);
InitializeWorkerPool(kReclaimTimeForDetachTests, kNumWorkersInWorkerPool);
- auto task_runner = worker_pool_->CreateTaskRunnerWithTraits(TaskTraits());
+ auto task_runner =
+ worker_pool_->CreateTaskRunnerWithTraits(TaskTraits().WithWait());
// Post tasks to saturate the pool.
std::vector<std::unique_ptr<WaitableEvent>> task_started_events;
« no previous file with comments | « no previous file | base/task_scheduler/task_tracker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698