Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2531653002: [api] Support sharing prototypes between FunctionTemplates (Closed)

Created:
4 years ago by Camillo Bruni
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Support sharing prototypes between FunctionTemplates FunctionTemplateInfo::SetPrototypeProviderTemplate adds support for sharing prototypes between several function templates. This is used to properly set up Image.prototype and HTMLImageElement.protoype which should be equal according to the spec. BUG=chromium:2969 Committed: https://crrev.com/85321456cd1c52575babad6c9c7a1f6869087882 Cr-Commit-Position: refs/heads/master@{#41343}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updating todo #

Patch Set 3 : don't use deprecated api #

Patch Set 4 : fixing unittest #

Patch Set 5 : another update #

Patch Set 6 : fixing test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -22 lines) Patch
M include/v8.h View 2 chunks +13 lines, -1 line 0 comments Download
M src/api.cc View 2 chunks +13 lines, -2 lines 0 comments Download
M src/api-natives.cc View 1 4 chunks +37 lines, -18 lines 0 comments Download
M src/objects.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 5 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
Camillo Bruni
PTAL
4 years ago (2016-11-24 17:54:14 UTC) #4
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/2531653002/diff/1/src/api-natives.cc File src/api-natives.cc (right): https://codereview.chromium.org/2531653002/diff/1/src/api-natives.cc#newcode411 src/api-natives.cc:411: // TODO(dcarney): decide what to do here. maybe ...
4 years ago (2016-11-25 06:46:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2531653002/80001
4 years ago (2016-11-29 09:05:14 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/12935) v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years ago (2016-11-29 09:09:46 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2531653002/100001
4 years ago (2016-11-29 09:24:46 UTC) #19
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years ago (2016-11-29 10:13:54 UTC) #21
commit-bot: I haz the power
4 years ago (2016-11-29 10:14:30 UTC) #23
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/85321456cd1c52575babad6c9c7a1f6869087882
Cr-Commit-Position: refs/heads/master@{#41343}

Powered by Google App Engine
This is Rietveld 408576698