Add some methods in CPDF_ImageRenderer

Add some methods in CPDF_ImageRenderer

Made a member private and added some methods to reduce code duplication

Committed: https://pdfium.googlesource.com/pdfium/+/3c0f366daafed42495b22ecbdda8f21f3f939d9b

[npm, 2016-11-24 17:44:30]

npm@chromium.org changed reviewers:
+ dsinclair@chromium.org, tsepez@chromium.org

[npm, 2016-11-24 17:44:31]

ptal

[npm, 2016-11-25 00:11:13]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 00:11:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 00:35:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 00:35:27]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-11-28 18:42:53]

https://codereview.chromium.org/2531643002/diff/1/core/fpdfapi/render/cpdf_im...
File core/fpdfapi/render/cpdf_imagerenderer.cpp (right):

https://codereview.chromium.org/2531643002/diff/1/core/fpdfapi/render/cpdf_im...
core/fpdfapi/render/cpdf_imagerenderer.cpp:231: m_Result = false;
I'd prefer to make this a const method, and make the callers set m_Result, even
thought there's more duplication.

https://codereview.chromium.org/2531643002/diff/1/core/fpdfapi/render/cpdf_im...
core/fpdfapi/render/cpdf_imagerenderer.cpp:268:
(uint8_t*)pBitmapDevice1->GetBitmap()->GetScanline(row);
nit: const_cast<uint8_t*>() so that we know that its needs investigation later.

https://codereview.chromium.org/2531643002/diff/1/core/fpdfapi/render/cpdf_im...
core/fpdfapi/render/cpdf_imagerenderer.cpp:564: bool
CPDF_ImageRenderer::GetResult() {
nit: a one-liner like this can go in the header.

https://codereview.chromium.org/2531643002/diff/1/core/fpdfapi/render/cpdf_im...
File core/fpdfapi/render/cpdf_imagerenderer.h (right):

https://codereview.chromium.org/2531643002/diff/1/core/fpdfapi/render/cpdf_im...
core/fpdfapi/render/cpdf_imagerenderer.h:14: class CFX_FxgeDevice;
nit: CFXGE_Device someday (since its in core/fxge)?

https://codereview.chromium.org/2531643002/diff/1/core/fpdfapi/render/cpdf_im...
core/fpdfapi/render/cpdf_imagerenderer.h:42: bool GetResult();
nit: bool GetResult() const; if possible.

https://codereview.chromium.org/2531643002/diff/1/core/fpdfapi/render/cpdf_im...
core/fpdfapi/render/cpdf_imagerenderer.h:51: bool NotDrawing();
nit: any of these new methods also const?

https://codereview.chromium.org/2531643002/diff/1/core/fpdfapi/render/cpdf_re...
File core/fpdfapi/render/cpdf_renderstatus.cpp (right):

https://codereview.chromium.org/2531643002/diff/1/core/fpdfapi/render/cpdf_re...
core/fpdfapi/render/cpdf_renderstatus.cpp:2378: if (render.Start(this,
pImageObj, pObj2Device, m_bStdCS, m_curBlend)) {
nit: no {}

[npm, 2016-11-28 20:51:30]

https://codereview.chromium.org/2531643002/diff/1/core/fpdfapi/render/cpdf_im...
File core/fpdfapi/render/cpdf_imagerenderer.cpp (right):

https://codereview.chromium.org/2531643002/diff/1/core/fpdfapi/render/cpdf_im...
core/fpdfapi/render/cpdf_imagerenderer.cpp:231: m_Result = false;
On 2016/11/28 18:42:53, Tom Sepez wrote:
> I'd prefer to make this a const method, and make the callers set m_Result,
even
> thought there's more duplication.

Done.

https://codereview.chromium.org/2531643002/diff/1/core/fpdfapi/render/cpdf_im...
core/fpdfapi/render/cpdf_imagerenderer.cpp:268:
(uint8_t*)pBitmapDevice1->GetBitmap()->GetScanline(row);
On 2016/11/28 18:42:53, Tom Sepez wrote:
> nit: const_cast<uint8_t*>() so that we know that its needs investigation
later.

Done.

https://codereview.chromium.org/2531643002/diff/1/core/fpdfapi/render/cpdf_im...
core/fpdfapi/render/cpdf_imagerenderer.cpp:564: bool
CPDF_ImageRenderer::GetResult() {
On 2016/11/28 18:42:53, Tom Sepez wrote:
> nit: a one-liner like this can go in the header.

Done.

https://codereview.chromium.org/2531643002/diff/1/core/fpdfapi/render/cpdf_im...
File core/fpdfapi/render/cpdf_imagerenderer.h (right):

https://codereview.chromium.org/2531643002/diff/1/core/fpdfapi/render/cpdf_im...
core/fpdfapi/render/cpdf_imagerenderer.h:14: class CFX_FxgeDevice;
On 2016/11/28 18:42:53, Tom Sepez wrote:
> nit: CFXGE_Device someday (since its in core/fxge)?

Ok, will do later

https://codereview.chromium.org/2531643002/diff/1/core/fpdfapi/render/cpdf_im...
core/fpdfapi/render/cpdf_imagerenderer.h:42: bool GetResult();
On 2016/11/28 18:42:53, Tom Sepez wrote:
> nit: bool GetResult() const; if possible.

Done.

https://codereview.chromium.org/2531643002/diff/1/core/fpdfapi/render/cpdf_im...
core/fpdfapi/render/cpdf_imagerenderer.h:51: bool NotDrawing();
On 2016/11/28 18:42:53, Tom Sepez wrote:
> nit: any of these new methods also const?

Done.

https://codereview.chromium.org/2531643002/diff/1/core/fpdfapi/render/cpdf_re...
File core/fpdfapi/render/cpdf_renderstatus.cpp (right):

https://codereview.chromium.org/2531643002/diff/1/core/fpdfapi/render/cpdf_re...
core/fpdfapi/render/cpdf_renderstatus.cpp:2378: if (render.Start(this,
pImageObj, pObj2Device, m_bStdCS, m_curBlend)) {
On 2016/11/28 18:42:53, Tom Sepez wrote:
> nit: no {}

Done.

[Tom Sepez, 2016-11-28 21:23:28]

lgtm

[npm, 2016-11-28 21:38:06]

The CQ bit was checked by npm@chromium.org

[commit-bot: I haz the power, 2016-11-28 21:38:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 21:51:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480369086699070,
"parent_rev": "239915200225fea4c5a02e9630044ef13fccb66d", "commit_rev":
"3c0f366daafed42495b22ecbdda8f21f3f939d9b"}

[commit-bot: I haz the power, 2016-11-28 21:51:31]

Description was changed from

==========
Add some methods in CPDF_ImageRenderer

Made a member private and added some methods to reduce code duplication
==========

to

==========
Add some methods in CPDF_ImageRenderer

Made a member private and added some methods to reduce code duplication

Committed:
https://pdfium.googlesource.com/pdfium/+/3c0f366daafed42495b22ecbdda8f21f3f93...
==========

[commit-bot: I haz the power, 2016-11-28 21:51:32]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/3c0f366daafed42495b22ecbdda8f21f3f93...