Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 253163002: Add media size select element and ticket item. Do not expose in the UI yet. (Closed)

Created:
6 years, 7 months ago by Aleksey Shlyapnikov
Modified:
6 years, 7 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Add media size select element and ticket item. Do not expose in the UI yet. BUG=239879 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267090

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address cl comments. #

Patch Set 3 : Address cl comments. #

Messages

Total messages: 6 (0 generated)
Aleksey Shlyapnikov
6 years, 7 months ago (2014-04-29 18:55:18 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm https://codereview.chromium.org/253163002/diff/1/chrome/browser/resources/print_preview/data/ticket_items/media_size.js File chrome/browser/resources/print_preview/data/ticket_items/media_size.js (right): https://codereview.chromium.org/253163002/diff/1/chrome/browser/resources/print_preview/data/ticket_items/media_size.js#newcode1 chrome/browser/resources/print_preview/data/ticket_items/media_size.js:1: // Copyright (c) 2014 The Chromium Authors. All ...
6 years, 7 months ago (2014-04-29 19:01:52 UTC) #2
Aleksey Shlyapnikov
https://codereview.chromium.org/253163002/diff/1/chrome/browser/resources/print_preview/data/ticket_items/media_size.js File chrome/browser/resources/print_preview/data/ticket_items/media_size.js (right): https://codereview.chromium.org/253163002/diff/1/chrome/browser/resources/print_preview/data/ticket_items/media_size.js#newcode1 chrome/browser/resources/print_preview/data/ticket_items/media_size.js:1: // Copyright (c) 2014 The Chromium Authors. All rights ...
6 years, 7 months ago (2014-04-29 19:35:48 UTC) #3
Aleksey Shlyapnikov
The CQ bit was checked by alekseys@chromium.org
6 years, 7 months ago (2014-04-29 19:36:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/253163002/30001
6 years, 7 months ago (2014-04-29 19:37:19 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 05:34:46 UTC) #6
Message was sent while issue was closed.
Change committed as 267090

Powered by Google App Engine
This is Rietveld 408576698