third_party/WebKit/LayoutTests/compositing/layer-creation/iframe-background-attachment-fixed.html - Issue 2531603003: Only scroll on main if the targeted frames need to scroll on main

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/compositing/layer-creation/iframe-background-attachment-fixed.html

Issue 2531603003: Only scroll on main if the targeted frames need to scroll on main (Closed)

Patch Set: Resolve conflict Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/compositing/layer-creation/iframe-background-attachment-fixed-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/compositing/layer-creation/iframe-background-attachment-fixed.html

diff --git a/third_party/WebKit/LayoutTests/compositing/layer-creation/iframe-background-attachment-fixed.html b/third_party/WebKit/LayoutTests/compositing/layer-creation/iframe-background-attachment-fixed.html

index 731fbd1efb48e104d36bf7918ca16107e0d7886d..d2abd4cf06d8d53e36c1f2744c8ab1557ca8ba47 100644

--- a/third_party/WebKit/LayoutTests/compositing/layer-creation/iframe-background-attachment-fixed.html

+++ b/third_party/WebKit/LayoutTests/compositing/layer-creation/iframe-background-attachment-fixed.html

@@ -1,10 +1,23 @@

<!DOCTYPE html>

-<iframe src="resources/background-attachment-fixed.html"></iframe>

+<iframe id="iframe" src="resources/background-attachment-fixed.html"></iframe>

+<div style="height: 2000px;">

+</div>

+function scrollingLocationAndReasons(reasons) {

+ return reasons ? "scrolls on main: " + reasons : "scrolls on impl";

if (window.testRunner)

testRunner.dumpAsText(true);

window.addEventListener('load', function() {

- document.getElementById("mainThreadScrollingReasons").innerText = window.internals.mainThreadScrollingReasons(document);

+ reasons = window.internals.mainThreadScrollingReasons(document);

+ text = "Main frame " + scrollingLocationAndReasons(reasons);

+ text += "\nThe iFrame scrolls on main thread, reasons: " + document.getElementById("iframe").contentDocument.getElementById("mainThreadScrollingReasons").innerText;

+ document.getElementById("mainThreadScrollingReasons").innerText = text;

});

</script>