third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp - Issue 2531603003: Only scroll on main if the targeted frames need to scroll on main

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2531603003: Only scroll on main if the targeted frames need to scroll on main (Closed)

Patch Set: Fix compiling error due to using backslash at the end of a commenting line" Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

index ac22ac5ab04f247e1d77926b9acabb6a835c8cac..4d09151d6e3ecb27481b42b2acc03afb23e8d169 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

@@ -1705,11 +1705,8 @@ bool PaintLayerScrollableArea::usesCompositedScrolling() const {

bool PaintLayerScrollableArea::shouldScrollOnMainThread() const {

if (LocalFrame* frame = box().frame()) {

- if (Page* page = frame->page()) {

- if (page->scrollingCoordinator()

- ->shouldUpdateScrollLayerPositionOnMainThread())

- return true;

- }

+ if (frame->view()->mainThreadScrollingReasons())

+ return true;

}

return ScrollableArea::shouldScrollOnMainThread();

}