third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp - Issue 2531603003: Only scroll on main if the targeted frames need to scroll on main

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2531603003: Only scroll on main if the targeted frames need to scroll on main (Closed)

Patch Set: Moving mainThreadScrollingReason related function from ScrollingCoordinator to FrameView to indicat… Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

index e50d441318e02d9e712f2b5845123466b39657b5..658bf3e00a7a6bfbea89e3c2409f81c758124204 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

@@ -1724,11 +1724,8 @@ bool PaintLayerScrollableArea::usesCompositedScrolling() const {

bool PaintLayerScrollableArea::shouldScrollOnMainThread() const {

if (LocalFrame* frame = box().frame()) {

- if (Page* page = frame->page()) {

- if (page->scrollingCoordinator()

- ->shouldUpdateScrollLayerPositionOnMainThread())

- return true;

- }

+ if (frame->view()->mainThreadScrollingReasons())

+ return true;

}

return ScrollableArea::shouldScrollOnMainThread();

}