third_party/WebKit/Source/core/page/Page.cpp - Issue 2531603003: Only scroll on main if the targeted frames need to scroll on main

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/Page.cpp

Issue 2531603003: Only scroll on main if the targeted frames need to scroll on main (Closed)

Patch Set: Bug fix Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/Page.cpp

diff --git a/third_party/WebKit/Source/core/page/Page.cpp b/third_party/WebKit/Source/core/page/Page.cpp

index bcc4c7944f597920d7f7e1e3a8638cb9c095e1af..e85b62cf2c336d5d957bba2caa0121ad1dfc7b52 100644

--- a/third_party/WebKit/Source/core/page/Page.cpp

+++ b/third_party/WebKit/Source/core/page/Page.cpp

@@ -164,9 +164,9 @@ ScrollingCoordinator* Page::scrollingCoordinator() {

return m_scrollingCoordinator.get();

}

-String Page::mainThreadScrollingReasonsAsText() {

+String Page::mainThreadScrollingReasonsAsText(Frame* frame) {

if (ScrollingCoordinator* scrollingCoordinator = this->scrollingCoordinator())

- return scrollingCoordinator->mainThreadScrollingReasonsAsText();

+ return scrollingCoordinator->mainThreadScrollingReasonsAsText(frame);

return String();

}