Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2531603003: Only scroll on main if the targeted frames need to scroll on main (Closed)
Patch Set: Bug fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@gmail.com> 10 * Christian Biesinger <cbiesinger@gmail.com>
(...skipping 1688 matching lines...) Expand 10 before | Expand all | Expand 10 after
1699 // without this disabler. 1699 // without this disabler.
1700 DisableCompositingQueryAsserts disabler; 1700 DisableCompositingQueryAsserts disabler;
1701 return layer()->hasCompositedLayerMapping() && 1701 return layer()->hasCompositedLayerMapping() &&
1702 layer()->compositedLayerMapping()->scrollingLayer(); 1702 layer()->compositedLayerMapping()->scrollingLayer();
1703 } 1703 }
1704 1704
1705 bool PaintLayerScrollableArea::shouldScrollOnMainThread() const { 1705 bool PaintLayerScrollableArea::shouldScrollOnMainThread() const {
1706 if (LocalFrame* frame = box().frame()) { 1706 if (LocalFrame* frame = box().frame()) {
1707 if (Page* page = frame->page()) { 1707 if (Page* page = frame->page()) {
1708 if (page->scrollingCoordinator() 1708 if (page->scrollingCoordinator()
1709 ->shouldUpdateScrollLayerPositionOnMainThread()) 1709 ->shouldUpdateScrollLayerPositionOnMainThread(frame))
1710 return true; 1710 return true;
1711 } 1711 }
1712 } 1712 }
1713 return ScrollableArea::shouldScrollOnMainThread(); 1713 return ScrollableArea::shouldScrollOnMainThread();
1714 } 1714 }
1715 1715
1716 static bool layerNeedsCompositedScrolling( 1716 static bool layerNeedsCompositedScrolling(
1717 PaintLayerScrollableArea::LCDTextMode mode, 1717 PaintLayerScrollableArea::LCDTextMode mode,
1718 const PaintLayer* layer) { 1718 const PaintLayer* layer) {
1719 if (!layer->scrollsOverflow()) 1719 if (!layer->scrollsOverflow())
(...skipping 296 matching lines...) Expand 10 before | Expand all | Expand 10 after
2016 2016
2017 void PaintLayerScrollableArea::DelayScrollOffsetClampScope:: 2017 void PaintLayerScrollableArea::DelayScrollOffsetClampScope::
2018 clampScrollableAreas() { 2018 clampScrollableAreas() {
2019 for (auto& scrollableArea : *s_needsClamp) 2019 for (auto& scrollableArea : *s_needsClamp)
2020 scrollableArea->clampScrollOffsetAfterOverflowChange(); 2020 scrollableArea->clampScrollOffsetAfterOverflowChange();
2021 delete s_needsClamp; 2021 delete s_needsClamp;
2022 s_needsClamp = nullptr; 2022 s_needsClamp = nullptr;
2023 } 2023 }
2024 2024
2025 } // namespace blink 2025 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698