Parser: store parameters in a ThreadedList instead of ZoneList.

Parser: store parameters in a ThreadedList instead of ZoneList.

ThreadedList is more memory-efficient than ZoneList. This also enables
us to use ThreadedList when making Preparser track parameters (upcoming
work).

BUG=v8:5501
Committed: https://crrev.com/b31cbbd443a91c18b8e6a5e8681425cb4fcf3ec6
Cr-Commit-Position: refs/heads/master@{#41307}

[marja, 2016-11-24 14:38:01]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 14:38:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marja, 2016-11-24 14:38:43]

Description was changed from

==========
Parser: put parameters into Zone instead of storing them on the stack.

Also store actual parameters in a ThreadedList instead of ZoneList.

ThreadedList is more memory-efficient than ZoneList. This also enables
us to use ThreadedList when making Preparser track parameters (upcoming
work).


BUG=
==========

to

==========
Parser: put parameters into Zone instead of storing them on the stack.

Also store actual parameters in a ThreadedList instead of ZoneList.

ThreadedList is more memory-efficient than ZoneList. This also enables
us to use ThreadedList when making Preparser track parameters (upcoming
work).


BUG=v8:5501
==========

[marja, 2016-11-24 14:41:52]

marja@chromium.org changed reviewers:
+ verwaest@chromium.org

[marja, 2016-11-24 14:41:53]

ptal

[commit-bot: I haz the power, 2016-11-24 15:06:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 15:06:55]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2016-11-24 15:09:41]

overall this looks good, just a Q

https://codereview.chromium.org/2531593002/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2531593002/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:953: ParserFormalParameters* formals =
Are you sure you need formals to be zone allocated? It's hard to tell from the
diff here...

https://codereview.chromium.org/2531593002/diff/1/src/parsing/parser.h
File src/parsing/parser.h (left):

https://codereview.chromium.org/2531593002/diff/1/src/parsing/parser.h#oldcod...
src/parsing/parser.h:159: ZoneList<Parameter> params;
Oh my... it didn't use Parameter* ... good thing your changes this :)

[marja, 2016-11-25 08:02:24]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 08:02:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 08:23:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 08:23:05]

Dry run: Try jobs failed on following builders:
  v8_linux_chromium_gn_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)

[marja, 2016-11-25 10:08:23]

https://codereview.chromium.org/2531593002/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2531593002/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:953: ParserFormalParameters* formals =
On 2016/11/24 15:09:41, Toon Verwaest wrote:
> Are you sure you need formals to be zone allocated? It's hard to tell from the
> diff here...

Done.

[marja, 2016-11-25 10:28:04]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 10:28:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 10:57:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 10:57:16]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2016-11-28 10:45:39]

lgtm

[marja, 2016-11-28 10:54:29]

Description was changed from

==========
Parser: put parameters into Zone instead of storing them on the stack.

Also store actual parameters in a ThreadedList instead of ZoneList.

ThreadedList is more memory-efficient than ZoneList. This also enables
us to use ThreadedList when making Preparser track parameters (upcoming
work).


BUG=v8:5501
==========

to

==========
Parser: store parameters in a ThreadedList instead of ZoneList.

ThreadedList is more memory-efficient than ZoneList. This also enables
us to use ThreadedList when making Preparser track parameters (upcoming
work).


BUG=v8:5501
==========

[marja, 2016-11-28 10:55:16]

The CQ bit was checked by marja@chromium.org

[commit-bot: I haz the power, 2016-11-28 10:55:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 11:23:39]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480330516077510,
"parent_rev": "336e3ad5adbc13b385dc973b4292966f9cd7fc51", "commit_rev":
"8790daca3f527582714feb732d15a201de2d1118"}

[commit-bot: I haz the power, 2016-11-28 11:23:42]

Description was changed from

==========
Parser: store parameters in a ThreadedList instead of ZoneList.

ThreadedList is more memory-efficient than ZoneList. This also enables
us to use ThreadedList when making Preparser track parameters (upcoming
work).


BUG=v8:5501
==========

to

==========
Parser: store parameters in a ThreadedList instead of ZoneList.

ThreadedList is more memory-efficient than ZoneList. This also enables
us to use ThreadedList when making Preparser track parameters (upcoming
work).


BUG=v8:5501
==========

[commit-bot: I haz the power, 2016-11-28 11:23:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-28 11:24:17]

Description was changed from

==========
Parser: store parameters in a ThreadedList instead of ZoneList.

ThreadedList is more memory-efficient than ZoneList. This also enables
us to use ThreadedList when making Preparser track parameters (upcoming
work).


BUG=v8:5501
==========

to

==========
Parser: store parameters in a ThreadedList instead of ZoneList.

ThreadedList is more memory-efficient than ZoneList. This also enables
us to use ThreadedList when making Preparser track parameters (upcoming
work).

BUG=v8:5501

Committed: https://crrev.com/b31cbbd443a91c18b8e6a5e8681425cb4fcf3ec6
Cr-Commit-Position: refs/heads/master@{#41307}
==========

[commit-bot: I haz the power, 2016-11-28 11:24:18]

Patchset 3 (id:??) landed as
https://crrev.com/b31cbbd443a91c18b8e6a5e8681425cb4fcf3ec6
Cr-Commit-Position: refs/heads/master@{#41307}