Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 2531573002: customtabs: Output all the available metrics after a timeout. (Closed)

Created:
4 years ago by Benoit L
Modified:
4 years ago
Reviewers:
droger
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

customtabs: Output all the available metrics after a timeout. Some pages never really finish loading, even though for most benchmarks we are interested in the first contentful paint timings, that are more commonly reported. Change the java benchmark app and the driver script to output the available metrics after a delay. Also some minor cleanups in the code. BUG=655980 Committed: https://crrev.com/a7371fec73920e104f4ca790572c5b869b22eb08 Cr-Commit-Position: refs/heads/master@{#434327}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -36 lines) Patch
M tools/android/customtabs_benchmark/java/src/org/chromium/customtabs/test/MainActivity.java View 9 chunks +42 lines, -32 lines 0 comments Download
M tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py View 1 4 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Benoit L
4 years ago (2016-11-24 13:54:38 UTC) #3
droger
https://codereview.chromium.org/2531573002/diff/1/tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py File tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py (right): https://codereview.chromium.org/2531573002/diff/1/tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py#newcode95 tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py:95: + delay_to_launch_url / 1000.) + 3; Why is delay_to_launch_url ...
4 years ago (2016-11-24 14:08:10 UTC) #4
Benoit L
Thanks! https://codereview.chromium.org/2531573002/diff/1/tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py File tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py (right): https://codereview.chromium.org/2531573002/diff/1/tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py#newcode95 tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py:95: + delay_to_launch_url / 1000.) + 3; On 2016/11/24 ...
4 years ago (2016-11-24 14:34:17 UTC) #5
droger
lgtm
4 years ago (2016-11-24 14:39:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2531573002/20001
4 years ago (2016-11-24 15:03:50 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-24 15:28:02 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-24 15:31:00 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a7371fec73920e104f4ca790572c5b869b22eb08
Cr-Commit-Position: refs/heads/master@{#434327}

Powered by Google App Engine
This is Rietveld 408576698