customtabs: Output all the available metrics after a timeout.

customtabs: Output all the available metrics after a timeout.

Some pages never really finish loading, even though for most benchmarks
we are interested in the first contentful paint timings, that are more
commonly reported.

Change the java benchmark app and the driver script to output the
available metrics after a delay. Also some minor cleanups in the code.

BUG=655980
Committed: https://crrev.com/a7371fec73920e104f4ca790572c5b869b22eb08
Cr-Commit-Position: refs/heads/master@{#434327}

[Benoit L, 2016-11-24 13:54:15]

Description was changed from

==========
customtabs: Output all the available metrics after a timeout.

Some pages never really finish loading, even though for most benchmarks
we are interested in the first contentful paint timings, that are more
commonly reported.

Change the java benchmark app and the driver script to output the
available metrics after a delay. Also some minor cleanups in the code.
==========

to

==========
customtabs: Output all the available metrics after a timeout.

Some pages never really finish loading, even though for most benchmarks
we are interested in the first contentful paint timings, that are more
commonly reported.

Change the java benchmark app and the driver script to output the
available metrics after a delay. Also some minor cleanups in the code.

BUG=655980
==========

[Benoit L, 2016-11-24 13:54:37]

lizeb@chromium.org changed reviewers:
+ droger@chromium.org

[droger, 2016-11-24 14:08:10]

https://codereview.chromium.org/2531573002/diff/1/tools/android/customtabs_be...
File tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py (right):

https://codereview.chromium.org/2531573002/diff/1/tools/android/customtabs_be...
tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py:95: +
delay_to_launch_url / 1000.) + 3;
Why is delay_to_launch_url repeated? did you mean delay_to_may_launch_url?

[Benoit L, 2016-11-24 14:34:17]

Thanks!

https://codereview.chromium.org/2531573002/diff/1/tools/android/customtabs_be...
File tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py (right):

https://codereview.chromium.org/2531573002/diff/1/tools/android/customtabs_be...
tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py:95: +
delay_to_launch_url / 1000.) + 3;
On 2016/11/24 14:08:10, droger wrote:
> Why is delay_to_launch_url repeated? did you mean delay_to_may_launch_url?

Oops, thanks!
Done.

[droger, 2016-11-24 14:39:05]

lgtm

[Benoit L, 2016-11-24 15:03:13]

The CQ bit was checked by lizeb@chromium.org

[commit-bot: I haz the power, 2016-11-24 15:03:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 15:27:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479999793039810,
"parent_rev": "cd71dedc811a3c1f9a25ac2acb3a063bd606837f", "commit_rev":
"c43540179482e4e1ea7ea046f902028e50ef33d7"}

[commit-bot: I haz the power, 2016-11-24 15:28:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-24 15:30:59]

Description was changed from

==========
customtabs: Output all the available metrics after a timeout.

Some pages never really finish loading, even though for most benchmarks
we are interested in the first contentful paint timings, that are more
commonly reported.

Change the java benchmark app and the driver script to output the
available metrics after a delay. Also some minor cleanups in the code.

BUG=655980
==========

to

==========
customtabs: Output all the available metrics after a timeout.

Some pages never really finish loading, even though for most benchmarks
we are interested in the first contentful paint timings, that are more
commonly reported.

Change the java benchmark app and the driver script to output the
available metrics after a delay. Also some minor cleanups in the code.

BUG=655980

Committed: https://crrev.com/a7371fec73920e104f4ca790572c5b869b22eb08
Cr-Commit-Position: refs/heads/master@{#434327}
==========

[commit-bot: I haz the power, 2016-11-24 15:31:00]

Patchset 2 (id:??) landed as
https://crrev.com/a7371fec73920e104f4ca790572c5b869b22eb08
Cr-Commit-Position: refs/heads/master@{#434327}