Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2531563002: [wrapper-tracing] Fix leak in RemotePlayback round 2 (Closed)

Created:
4 years ago by Michael Lippautz
Modified:
4 years ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[wrapper-tracing] Fix leak in RemotePlayback round 2 BUG=chromium:667746 Committed: https://crrev.com/68e0614944ce7c45de33bc8722df414eddf7a0a8 Cr-Commit-Position: refs/heads/master@{#434382}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 26 (16 generated)
Michael Lippautz
Fixes the last test that triggers the leak detector
4 years ago (2016-11-24 13:39:28 UTC) #3
Marcel Hlopko
lgtm
4 years ago (2016-11-24 14:01:35 UTC) #7
haraken
LGTM
4 years ago (2016-11-24 14:06:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2531563002/1
4 years ago (2016-11-24 15:00:31 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/344241)
4 years ago (2016-11-24 15:28:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2531563002/1
4 years ago (2016-11-24 17:18:26 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/277716)
4 years ago (2016-11-24 18:31:06 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2531563002/1
4 years ago (2016-11-24 18:44:39 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 19:44:08 UTC) #24
commit-bot: I haz the power
4 years ago (2016-11-24 19:46:50 UTC) #26
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/68e0614944ce7c45de33bc8722df414eddf7a0a8
Cr-Commit-Position: refs/heads/master@{#434382}

Powered by Google App Engine
This is Rietveld 408576698