Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: chrome/browser/chromeos/login/session/chrome_session_manager.cc

Issue 2531543003: Resolve initialize/destory order between ArcService and ArcSessionManager. (Closed)
Patch Set: Address comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/session/chrome_session_manager.cc
diff --git a/chrome/browser/chromeos/login/session/chrome_session_manager.cc b/chrome/browser/chromeos/login/session/chrome_session_manager.cc
index a2bf78b6de21cbd44ef370240d77a449cbe02b16..194efe6379c98e87ab6343df008c229fc507cdcb 100644
--- a/chrome/browser/chromeos/login/session/chrome_session_manager.cc
+++ b/chrome/browser/chromeos/login/session/chrome_session_manager.cc
@@ -15,7 +15,7 @@
#include "chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_manager.h"
#include "chrome/browser/chromeos/app_mode/kiosk_app_launch_error.h"
#include "chrome/browser/chromeos/app_mode/kiosk_app_manager.h"
-#include "chrome/browser/chromeos/arc/arc_session_manager.h"
+#include "chrome/browser/chromeos/arc/arc_service_launcher.h"
#include "chrome/browser/chromeos/boot_times_recorder.h"
#include "chrome/browser/chromeos/login/login_wizard.h"
#include "chrome/browser/chromeos/login/session/user_session_manager.h"
@@ -24,7 +24,6 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/signin/signin_manager_factory.h"
#include "chrome/browser/ui/ash/ash_util.h"
-#include "chrome/browser/ui/ash/multi_user/multi_user_util.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/pref_names.h"
#include "chromeos/audio/cras_audio_handler.h"
@@ -33,7 +32,6 @@
#include "chromeos/dbus/dbus_thread_manager.h"
#include "chromeos/dbus/session_manager_client.h"
#include "components/arc/arc_bridge_service.h"
-#include "components/arc/arc_service_manager.h"
#include "components/prefs/pref_service.h"
#include "components/signin/core/account_id/account_id.h"
#include "components/signin/core/browser/signin_manager.h"
@@ -111,15 +109,8 @@ void StartRestoreAfterCrashSession(Profile* user_profile,
if (arc::ArcBridgeService::GetEnabled(
base::CommandLine::ForCurrentProcess())) {
- DCHECK(arc::ArcServiceManager::Get());
- std::unique_ptr<BooleanPrefMember> arc_enabled_pref =
- base::MakeUnique<BooleanPrefMember>();
- arc_enabled_pref->Init(prefs::kArcEnabled, user_profile->GetPrefs());
- arc::ArcServiceManager::Get()->OnPrimaryUserProfilePrepared(
- multi_user_util::GetAccountIdFromProfile(user_profile),
- std::move(arc_enabled_pref));
- DCHECK(arc::ArcSessionManager::Get());
- arc::ArcSessionManager::Get()->OnPrimaryUserProfilePrepared(user_profile);
+ arc::ArcServiceLauncher::Get()->OnPrimaryUserProfilePrepared(
+ user_profile);
}
// Send the PROFILE_PREPARED notification and call SessionStarted()

Powered by Google App Engine
This is Rietveld 408576698