Revert of [base] Define CHECK comparison for signed vs. unsigned

src/wasm/wasm-objects.cc

Index: src/wasm/wasm-objects.cc
diff --git a/src/wasm/wasm-objects.cc b/src/wasm/wasm-objects.cc
index dab56c4e54f2bda29f2fc558480f77a4b3bf0fd1..717696dabcfc2a2f12bac3eb98c6c03a02cc184b 100644
--- a/src/wasm/wasm-objects.cc
+++ b/src/wasm/wasm-objects.cc
@@ -49,7 +49,7 @@
   DCHECK(value->IsHeapNumber());
   HeapNumber* num = HeapNumber::cast(value);
   CHECK_GE(num->value(), 0.0);
-  CHECK_LE(num->value(), kMaxUInt32);
+  CHECK_LE(num->value(), static_cast<double>(kMaxUInt32));
   return static_cast<uint32_t>(num->value());
 }
 
@@ -59,8 +59,8 @@
   }
   DCHECK(value->IsHeapNumber());
   HeapNumber* num = HeapNumber::cast(value);
-  CHECK_GE(num->value(), Smi::kMinValue);
-  CHECK_LE(num->value(), Smi::kMaxValue);
+  CHECK_GE(num->value(), static_cast<double>(Smi::kMinValue));
+  CHECK_LE(num->value(), static_cast<double>(Smi::kMaxValue));
   return static_cast<int32_t>(num->value());
 }
 
@@ -371,8 +371,9 @@
   DCHECK_GT(module()->functions.size(), func_index);
   WasmFunction& function = module()->functions[func_index];
   SeqOneByteString* bytes = ptr_to_module_bytes();
-  DCHECK_GE(bytes->length(), function.name_offset);
-  DCHECK_GE(bytes->length() - function.name_offset, function.name_length);
+  DCHECK_GE(static_cast<size_t>(bytes->length()), function.name_offset);
+  DCHECK_GE(static_cast<size_t>(bytes->length() - function.name_offset),
+            function.name_length);
   return Vector<const uint8_t>(bytes->GetCharsAddress() + function.name_offset,
                                function.name_length);
 }
@@ -380,7 +381,8 @@
 int WasmCompiledModule::GetFunctionOffset(uint32_t func_index) const {
   std::vector<WasmFunction>& functions = module()->functions;
   if (static_cast<uint32_t>(func_index) >= functions.size()) return -1;
-  DCHECK_GE(kMaxInt, functions[func_index].code_start_offset);
+  DCHECK_GE(static_cast<uint32_t>(kMaxInt),
+            functions[func_index].code_start_offset);
   return static_cast<int>(functions[func_index].code_start_offset);
 }