Revert of [base] Define CHECK comparison for signed vs. unsigned

src/wasm/wasm-interpreter.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/wasm/wasm-interpreter.h"
 
 #include "src/utils.h"
 #include "src/wasm/ast-decoder.h"
 #include "src/wasm/decoder.h"
 #include "src/wasm/wasm-external-refs.h"
@@ skipping 1155 matching lines @@
 
   int DoBreak(InterpreterCode* code, pc_t pc, size_t depth) {
     size_t bp = blocks_.size() - depth - 1;
     Block* target = &blocks_[bp];
     DoStackTransfer(target->sp, target->arity);
     blocks_.resize(bp);
     return LookupTarget(code, pc);
   }
 
   bool DoReturn(InterpreterCode** code, pc_t* pc, pc_t* limit, size_t arity) {
-    DCHECK_GT(frames_.size(), 0);
+    DCHECK_GT(frames_.size(), 0u);
     // Pop all blocks for this frame.
     while (!blocks_.empty() && blocks_.back().fp == frames_.size()) {
       blocks_.pop_back();
     }
 
     sp_t dest = frames_.back().sp;
     frames_.pop_back();
     if (frames_.size() == 0) {
       // A return from the last frame terminates the execution.
       state_ = WasmInterpreter::FINISHED;
@@ skipping 486 matching lines @@
                    code->start[pc], OpcodeName(code->start[pc]));
           UNREACHABLE();
       }
 
       pc += len;
     }
     UNREACHABLE();  // above decoding loop should run forever.
   }
 
   WasmVal Pop() {
-    DCHECK_GT(stack_.size(), 0);
-    DCHECK_GT(frames_.size(), 0);
+    DCHECK_GT(stack_.size(), 0u);
+    DCHECK_GT(frames_.size(), 0u);
     DCHECK_GT(stack_.size(), frames_.back().llimit());  // can't pop into locals
     WasmVal val = stack_.back();
     stack_.pop_back();
     return val;
   }
 
   void PopN(int n) {
-    DCHECK_GE(stack_.size(), n);
-    DCHECK_GT(frames_.size(), 0);
+    DCHECK_GE(stack_.size(), static_cast<size_t>(n));
+    DCHECK_GT(frames_.size(), 0u);
     size_t nsize = stack_.size() - n;
     DCHECK_GE(nsize, frames_.back().llimit());  // can't pop into locals
     stack_.resize(nsize);
   }
 
   WasmVal PopArity(size_t arity) {
     if (arity == 0) return WasmVal();
-    CHECK_EQ(1, arity);
+    CHECK_EQ(1u, arity);
     return Pop();
   }
 
   void Push(pc_t pc, WasmVal val) {
     // TODO(titzer): store PC as well?
     if (val.type != kAstStmt) stack_.push_back(val);
   }
 
   void TraceStack(const char* phase, pc_t pc) {
     if (FLAG_trace_wasm_interpreter) {
@@ skipping 173 matching lines @@
 
 ControlTransferMap WasmInterpreter::ComputeControlTransfersForTesting(
     Zone* zone, const byte* start, const byte* end) {
   ControlTransfers targets(zone, nullptr, nullptr, start, end);
   return targets.map_;
 }
 
 }  // namespace wasm
 }  // namespace internal
 }  // namespace v8