Revert of [base] Define CHECK comparison for signed vs. unsigned

src/wasm/wasm-debug.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/assert-scope.h"
 #include "src/debug/debug.h"
 #include "src/factory.h"
 #include "src/isolate.h"
 #include "src/wasm/module-decoder.h"
 #include "src/wasm/wasm-module.h"
@@ skipping 29 matching lines @@
   {
     Handle<ByteArray> asm_offset_tables =
         compiled_module->asm_js_offset_tables();
     DisallowHeapAllocation no_gc;
     const byte *bytes_start = asm_offset_tables->GetDataStartAddress();
     const byte *bytes_end = bytes_start + asm_offset_tables->length();
     asm_offsets = wasm::DecodeAsmJsOffsets(bytes_start, bytes_end);
   }
   // Wasm bytes must be valid and must contain asm.js offset table.
   DCHECK(asm_offsets.ok());
-  DCHECK_GE(kMaxInt, asm_offsets.val.size());
+  DCHECK_GE(static_cast<size_t>(kMaxInt), asm_offsets.val.size());
   int num_functions = static_cast<int>(asm_offsets.val.size());
-  DCHECK_EQ(wasm::GetNumberOfFunctions(handle(debug_info->wasm_instance())),
-            num_functions + compiled_module->module()->num_imported_functions);
+  DCHECK_EQ(
+      wasm::GetNumberOfFunctions(handle(debug_info->wasm_instance())),
+      static_cast<int>(num_functions +
+                       compiled_module->module()->num_imported_functions));
   Handle<FixedArray> all_tables =
       isolate->factory()->NewFixedArray(num_functions);
   debug_info->set(kWasmDebugInfoAsmJsOffsets, *all_tables);
   for (int func = 0; func < num_functions; ++func) {
     std::vector<std::pair<int, int>> &func_asm_offsets = asm_offsets.val[func];
     if (func_asm_offsets.empty()) continue;
     size_t array_size = 2 * kIntSize * func_asm_offsets.size();
-    CHECK_LE(array_size, kMaxInt);
+    CHECK_LE(array_size, static_cast<size_t>(kMaxInt));
     ByteArray *arr =
         *isolate->factory()->NewByteArray(static_cast<int>(array_size));
     all_tables->set(func, arr);
     int idx = 0;
     for (std::pair<int, int> p : func_asm_offsets) {
       // Byte offsets must be strictly monotonously increasing:
       DCHECK(idx == 0 || p.first > arr->get_int(idx - 2));
       arr->set_int(idx++, p.first);
       arr->set_int(idx++, p.second);
     }
@@ skipping 64 matching lines @@
       left = mid;
     } else {
       right = mid;
     }
   }
   // There should be an entry for each position that could show up on the stack
   // trace:
   DCHECK_EQ(byte_offset, offset_table->get_int(2 * left));
   return offset_table->get_int(2 * left + 1);
 }