Chromium Code Reviews

Unified Diff: src/ast.h

Issue 25315002: Revert "Defer allocation of native function literals." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « no previous file | src/ast.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast.h
diff --git a/src/ast.h b/src/ast.h
index 5c980648990ca0908bb16a782a099c20cfe84413..71a51aba156694736be332d5ea1bc765dd8683d9 100644
--- a/src/ast.h
+++ b/src/ast.h
@@ -97,7 +97,7 @@ namespace internal {
#define EXPRESSION_NODE_LIST(V) \
V(FunctionLiteral) \
- V(NativeFunctionLiteral) \
+ V(SharedFunctionInfoLiteral) \
V(Conditional) \
V(VariableProxy) \
V(Literal) \
@@ -2380,18 +2380,23 @@ class FunctionLiteral V8_FINAL : public Expression {
};
-class NativeFunctionLiteral V8_FINAL : public Expression {
+class SharedFunctionInfoLiteral V8_FINAL : public Expression {
public:
- DECLARE_NODE_TYPE(NativeFunctionLiteral)
+ DECLARE_NODE_TYPE(SharedFunctionInfoLiteral)
- Handle<String> name() const { return name_; }
+ Handle<SharedFunctionInfo> shared_function_info() const {
+ return shared_function_info_;
+ }
protected:
- NativeFunctionLiteral(Isolate* isolate, Handle<String> name)
- : Expression(isolate), name_(name) { }
+ SharedFunctionInfoLiteral(
+ Isolate* isolate,
+ Handle<SharedFunctionInfo> shared_function_info)
+ : Expression(isolate),
+ shared_function_info_(shared_function_info) { }
private:
- Handle<String> name_;
+ Handle<SharedFunctionInfo> shared_function_info_;
};
@@ -3232,10 +3237,11 @@ class AstNodeFactory V8_FINAL BASE_EMBEDDED {
return lit;
}
- NativeFunctionLiteral* NewNativeFunctionLiteral(Handle<String> name) {
- NativeFunctionLiteral* lit =
- new(zone_) NativeFunctionLiteral(isolate_, name);
- VISIT_AND_RETURN(NativeFunctionLiteral, lit)
+ SharedFunctionInfoLiteral* NewSharedFunctionInfoLiteral(
+ Handle<SharedFunctionInfo> shared_function_info) {
+ SharedFunctionInfoLiteral* lit =
+ new(zone_) SharedFunctionInfoLiteral(isolate_, shared_function_info);
+ VISIT_AND_RETURN(SharedFunctionInfoLiteral, lit)
}
ThisFunction* NewThisFunction() {
« no previous file with comments | « no previous file | src/ast.cc » ('j') | no next file with comments »

Powered by Google App Engine