Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2531483004: Don't disable the sticky mode when resizing the keyboard window. (Closed)

Created:
4 years ago by yhanada
Modified:
4 years ago
Reviewers:
bshe
CC:
chromium-reviews, oshima
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't disable the sticky mode when resizing the keyboard window. BUG=666478 TEST=Enable the on-screen keyboard and show the keyboard by pressing the icon on the tray, then check that the keyboard is in sticky mode. Committed: https://crrev.com/bb0113ed3588e2173caa6ecf717baada9820a243 Cr-Commit-Position: refs/heads/master@{#434558}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/keyboard/keyboard_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
yhanada
Hi bshe@, PTAL.
4 years ago (2016-11-25 10:29:23 UTC) #2
bshe
On 2016/11/25 10:29:23, yhanada wrote: > Hi bshe@, PTAL. lgtm
4 years ago (2016-11-25 15:07:09 UTC) #3
yhanada
On 2016/11/25 15:07:09, bshe wrote: > On 2016/11/25 10:29:23, yhanada wrote: > > Hi bshe@, ...
4 years ago (2016-11-25 22:10:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2531483004/1
4 years ago (2016-11-25 22:10:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2531483004/1
4 years ago (2016-11-25 23:54:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-26 00:30:30 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-26 00:32:35 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb0113ed3588e2173caa6ecf717baada9820a243
Cr-Commit-Position: refs/heads/master@{#434558}

Powered by Google App Engine
This is Rietveld 408576698