Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2531463002: [turbofan] Assign appropriate types to RegExp builtins. (Closed)

Created:
4 years ago by Benedikt Meurer
Modified:
4 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Assign appropriate types to RegExp builtins. Recognize a couple of builtins on the RegExp.prototype in the Typer and assign useful types to them, so we can optimize various checks on their results. R=yangguo@chromium.org BUG=v8:5267 Committed: https://crrev.com/d66aaedd0eb57af0b2130c8dfe3aae5a6ea335c9 Cr-Commit-Position: refs/heads/master@{#41240}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M src/compiler/typer.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years ago (2016-11-24 05:32:13 UTC) #1
Yang
lgtm. I think there are a couple more that you could add. String.prototype.indexOf, .replace, .search, ...
4 years ago (2016-11-24 05:38:32 UTC) #4
Benedikt Meurer
Indeed. They'll require some additional surgery (at least in case of .replace). Maybe jgruber@ can ...
4 years ago (2016-11-24 05:39:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2531463002/1
4 years ago (2016-11-24 05:39:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 06:01:49 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-24 06:02:20 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d66aaedd0eb57af0b2130c8dfe3aae5a6ea335c9
Cr-Commit-Position: refs/heads/master@{#41240}

Powered by Google App Engine
This is Rietveld 408576698