Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2531443003:
Searchbox API cleanup: Move getMostVisitedItemData to newTabPage (Closed)
|
Created:
4 years ago by Marc Treib Modified:
4 years ago Reviewers:
sfiera CC:
chromium-reviews, extensions-reviews_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, chromium-apps-reviews_chromium.org, kmadhusu+watch_chromium.org, Jered Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSearchbox API cleanup: Move getMostVisitedItemData to newTabPage
Prior to this CL, getMostVisitedItemData was defined in chrome.embeddedSearch.searchBox. This CL moves it to chrome.embeddedSearch.newTabPage where it belongs.
Tested: Both Google (single-iframe) and third-party (multi-iframe) NTPs still work.
BUG=628207
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/8d3b5a0a5d710c5bc3fe0132e7d301016a4cf858
Cr-Commit-Position: refs/heads/master@{#434397}
Patch Set 1 #
Messages
Total messages: 24 (19 generated)
Description was changed from ========== Searchbox API cleanup: Move getMostVisitedItemData to newTabPage BUG=628207 ========== to ========== Searchbox API cleanup: Move getMostVisitedItemData to newTabPage BUG=628207 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Searchbox API cleanup: Move getMostVisitedItemData to newTabPage BUG=628207 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Searchbox API cleanup: Move getMostVisitedItemData to newTabPage Prior to this CL, getMostVisitedItemData was defined in chrome.embeddedSearch.searchBox. This CL moves it to chrome.embeddedSearch.newTabPage where it belongs. Tested: Both Google (single-iframe) and third-party (multi-iframe) NTPs still work. BUG=628207 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
treib@chromium.org changed reviewers: + sfiera@chromium.org
One more small cleanup, PTAL!
LGTM
The CQ bit was checked by treib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by treib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by treib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by treib@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480018699741780, "parent_rev":
"0b3406e20afcbf3244d0766d05ca1a272efd9abe", "commit_rev":
"e57850db1c612536fed19a2445b95fa874ff267e"}
Message was sent while issue was closed.
Description was changed from ========== Searchbox API cleanup: Move getMostVisitedItemData to newTabPage Prior to this CL, getMostVisitedItemData was defined in chrome.embeddedSearch.searchBox. This CL moves it to chrome.embeddedSearch.newTabPage where it belongs. Tested: Both Google (single-iframe) and third-party (multi-iframe) NTPs still work. BUG=628207 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Searchbox API cleanup: Move getMostVisitedItemData to newTabPage Prior to this CL, getMostVisitedItemData was defined in chrome.embeddedSearch.searchBox. This CL moves it to chrome.embeddedSearch.newTabPage where it belongs. Tested: Both Google (single-iframe) and third-party (multi-iframe) NTPs still work. BUG=628207 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Searchbox API cleanup: Move getMostVisitedItemData to newTabPage Prior to this CL, getMostVisitedItemData was defined in chrome.embeddedSearch.searchBox. This CL moves it to chrome.embeddedSearch.newTabPage where it belongs. Tested: Both Google (single-iframe) and third-party (multi-iframe) NTPs still work. BUG=628207 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Searchbox API cleanup: Move getMostVisitedItemData to newTabPage Prior to this CL, getMostVisitedItemData was defined in chrome.embeddedSearch.searchBox. This CL moves it to chrome.embeddedSearch.newTabPage where it belongs. Tested: Both Google (single-iframe) and third-party (multi-iframe) NTPs still work. BUG=628207 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8d3b5a0a5d710c5bc3fe0132e7d301016a4cf858 Cr-Commit-Position: refs/heads/master@{#434397} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8d3b5a0a5d710c5bc3fe0132e7d301016a4cf858 Cr-Commit-Position: refs/heads/master@{#434397} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
