Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2531363002: headless: Fix inconsistent header naming (Closed)

Created:
4 years ago by Sami
Modified:
4 years ago
Reviewers:
altimin
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Fix inconsistent header naming Because of a missing 's' the generated client API was always considered out of date. BUG=669077 Committed: https://crrev.com/fa434b649b61214ed73ed6a7b4354984ea81a2c2 Cr-Commit-Position: refs/heads/master@{#434699}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -51 lines) Patch
M headless/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M headless/lib/browser/devtools_api/client_api_generator.py View 1 chunk +2 lines, -2 lines 0 comments Download
D headless/lib/browser/devtools_api/domain_types_forward_declaration_h.template View 1 chunk +0 lines, -44 lines 0 comments Download
A + headless/lib/browser/devtools_api/domain_types_forward_declarations_h.template View 2 chunks +3 lines, -3 lines 0 comments Download
M headless/lib/browser/devtools_api/domain_types_h.template View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Sami
4 years ago (2016-11-28 17:13:00 UTC) #3
altimin
oops, my bad. lgtm, thanks!
4 years ago (2016-11-28 17:16:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2531363002/1
4 years ago (2016-11-28 17:37:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 18:28:49 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-28 18:30:21 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa434b649b61214ed73ed6a7b4354984ea81a2c2
Cr-Commit-Position: refs/heads/master@{#434699}

Powered by Google App Engine
This is Rietveld 408576698