third_party/WebKit/Source/core/page/scrolling/RootScrollerUtil.cpp - Issue 2531343002: Don't assume current root scroller is a LayoutBox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/RootScrollerUtil.cpp

Issue 2531343002: Don't assume current root scroller is a LayoutBox. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/scrolling/RootScrollerUtil.cpp

diff --git a/third_party/WebKit/Source/core/page/scrolling/RootScrollerUtil.cpp b/third_party/WebKit/Source/core/page/scrolling/RootScrollerUtil.cpp

index 1325221e5aef0c91d6cbce4ca556dc62819d32a2..6d80002a3c95ff1214c4d605f69bb1102d65de25 100644

--- a/third_party/WebKit/Source/core/page/scrolling/RootScrollerUtil.cpp

+++ b/third_party/WebKit/Source/core/page/scrolling/RootScrollerUtil.cpp

@@ -36,10 +36,9 @@ ScrollableArea* scrollableAreaForRootScroller(const Element& element) {

}

PaintLayer* paintLayerForRootScroller(const Element* element) {

- if (!element || !element->layoutObject())

+ if (!element || !element->layoutObject() || !element->layoutObject()->isBox())

return nullptr;

- DCHECK(element->layoutObject()->isBox());

LayoutBox* box = toLayoutBox(element->layoutObject());

// If the root scroller is the <html> element we do a bit of a fake out

« no previous file with comments | « no previous file | third_party/WebKit/Source/web/tests/RootScrollerTest.cpp » ('j') | no next file with comments »