Avoid a crash during summary linking when there are inheritance errors.

Avoid a crash during summary linking when there are inheritance errors.

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/636e7b559bb1fa5e48d840af71b4e2661fbe66e5

[Paul Berry, 2016-11-29 18:50:37]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[scheglov, 2016-11-29 18:57:41]

LGTM

[Brian Wilkerson, 2016-11-29 19:01:51]

lgtm

https://codereview.chromium.org/2531333006/diff/1/pkg/analyzer/lib/src/dart/r...
File pkg/analyzer/lib/src/dart/resolver/inheritance_manager.dart (right):

https://codereview.chromium.org/2531333006/diff/1/pkg/analyzer/lib/src/dart/r...
pkg/analyzer/lib/src/dart/resolver/inheritance_manager.dart:57: * Indicates
whether errors should be ignored.
Please add an explanation for why we need to not generate the errors in the
first place, given that it's easy for a client to ignore them.

https://codereview.chromium.org/2531333006/diff/1/pkg/analyzer/lib/src/dart/r...
pkg/analyzer/lib/src/dart/resolver/inheritance_manager.dart:667:
HashSet<AnalysisError> errorSet = _errorsInClassElement[classElt];
We could clean this up to use `putIfAbsent`, if you're so inclined.

[Paul Berry, 2016-11-29 19:03:46]

https://codereview.chromium.org/2531333006/diff/1/pkg/analyzer/lib/src/dart/r...
File pkg/analyzer/lib/src/dart/resolver/inheritance_manager.dart (right):

https://codereview.chromium.org/2531333006/diff/1/pkg/analyzer/lib/src/dart/r...
pkg/analyzer/lib/src/dart/resolver/inheritance_manager.dart:57: * Indicates
whether errors should be ignored.
On 2016/11/29 19:01:51, Brian Wilkerson wrote:
> Please add an explanation for why we need to not generate the errors in the
> first place, given that it's easy for a client to ignore them.

Done.

https://codereview.chromium.org/2531333006/diff/1/pkg/analyzer/lib/src/dart/r...
pkg/analyzer/lib/src/dart/resolver/inheritance_manager.dart:667:
HashSet<AnalysisError> errorSet = _errorsInClassElement[classElt];
On 2016/11/29 19:01:51, Brian Wilkerson wrote:
> We could clean this up to use `putIfAbsent`, if you're so inclined.

Acknowledged.

[Paul Berry, 2016-11-29 19:04:33]

Description was changed from

==========
Avoid a crash during summary linking when there are inheritance errors.
==========

to

==========
Avoid a crash during summary linking when there are inheritance errors.

R=brianwilkerson@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/636e7b559bb1fa5e48d840af71b4e2661fbe66e5
==========

[Paul Berry, 2016-11-29 19:04:34]

Committed patchset #1 (id:1) manually as
636e7b559bb1fa5e48d840af71b4e2661fbe66e5 (presubmit successful).