Unit tests of AudioInputRendererHost. Some cleanups.

content/browser/renderer_host/media/audio_input_renderer_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // AudioInputRendererHost serves audio related requests from audio capturer
 // which lives inside the render process and provide access to audio hardware.
 //
 // Create stream sequence (AudioInputController = AIC):
 //
 // AudioInputHostMsg_CreateStream -> OnCreateStream -> AIC::CreateLowLatency ->
@@ skipping 12 matching lines @@
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_MEDIA_AUDIO_INPUT_RENDERER_HOST_H_
 #define CONTENT_BROWSER_RENDERER_HOST_MEDIA_AUDIO_INPUT_RENDERER_HOST_H_
 
 #include <stdint.h>
 
 #include <map>
 #include <memory>
 #include <string>
 
-#include "base/compiler_specific.h"
-#include "base/macros.h"
 #include "base/memory/ref_counted.h"
-#include "base/memory/weak_ptr.h"
-#include "base/process/process.h"
-#include "base/sequenced_task_runner_helpers.h"
 #include "content/common/media/audio_messages.h"
 #include "content/public/browser/browser_message_filter.h"
-#include "content/public/browser/browser_thread.h"
 #include "media/audio/audio_input_controller.h"
-#include "media/audio/audio_io.h"
-#include "media/audio/audio_logging.h"
-#include "media/audio/simple_sources.h"
-#include "media/media_features.h"
 
 namespace media {
 class AudioManager;
 class UserInputMonitor;
 }
 
 namespace content {
 class AudioMirroringManager;
 class MediaStreamManager;
-class RenderProcessHost;
 
 class CONTENT_EXPORT AudioInputRendererHost
     : public BrowserMessageFilter,
       public media::AudioInputController::EventHandler {
  public:
-  // Error codes to make native loggin more clear. These error codes are added
+  // Error codes to make native logging more clear. These error codes are added
   // to generic error strings to provide a higher degree of details.
   // Changing these values can lead to problems when matching native debug
   // logs with the actual cause of error.
   enum ErrorCode {
     // An unspecified error occured.
     UNKNOWN_ERROR = 0,
 
     // Failed to look up audio intry for the provided stream id.
     INVALID_AUDIO_ENTRY,  // = 1
 
     // A stream with the specified stream id already exists.
     STREAM_ALREADY_EXISTS,  // = 2
 
     // The page does not have permission to open the specified capture device.
     PERMISSION_DENIED,  // = 3
 
     // Failed to create shared memory.
     SHARED_MEMORY_CREATE_FAILED,  // = 4
 
     // Failed to initialize the AudioInputSyncWriter instance.
     SYNC_WRITER_INIT_FAILED,  // = 5
 
     // Failed to create native audio input stream.
     STREAM_CREATE_ERROR,  // = 6
 
-    // Renderer process handle is invalid.
-    INVALID_PEER_HANDLE,  // = 7
-
-    // Only low-latency mode is supported.
-    INVALID_LATENCY_MODE,  // = 8
-
     // Failed to map and share the shared memory.
-    MEMORY_SHARING_FAILED,  // = 9
+    MEMORY_SHARING_FAILED,  // = 7,
 
     // Unable to prepare the foreign socket handle.
-    SYNC_SOCKET_ERROR,  // = 10
+    SYNC_SOCKET_ERROR,  // = 8,
 
     // This error message comes from the AudioInputController instance.
-    AUDIO_INPUT_CONTROLLER_ERROR,  // = 11
+    AUDIO_INPUT_CONTROLLER_ERROR,  // = 9,
   };
 
   // Called from UI thread from the owner of this object.
   // |user_input_monitor| is used for typing detection and can be NULL.
   AudioInputRendererHost(int render_process_id,
                          int32_t renderer_pid,
                          media::AudioManager* audio_manager,
                          MediaStreamManager* media_stream_manager,
                          AudioMirroringManager* audio_mirroring_manager,
                          media::UserInputMonitor* user_input_monitor);
@@ skipping 16 matching lines @@
                media::AudioInputController::ErrorCode error_code) override;
   void OnData(media::AudioInputController* controller,
               const media::AudioBus* data) override;
   void OnLog(media::AudioInputController* controller,
              const std::string& message) override;
 
   // Sets the PID renderer. This is used for constructing the debug recording
   // filename.
   void set_renderer_pid(int32_t renderer_pid);
 
+ protected:
+  ~AudioInputRendererHost() override;
+
  private:
-  // TODO(henrika): extend test suite (compare AudioRenderHost)
   friend class BrowserThread;
-  friend class TestAudioInputRendererHost;
   friend class base::DeleteHelper<AudioInputRendererHost>;
 
   struct AudioEntry;
   typedef std::map<int, AudioEntry*> AudioEntryMap;
 
-  ~AudioInputRendererHost() override;
-
   // Methods called on IO thread ----------------------------------------------
 
   // Audio related IPC message handlers.
 
   // For ChromeOS: Checks if the stream should contain keyboard mic, if so
   // registers to AudioInputDeviceManager. Then calls DoCreateStream.
   // For non-ChromeOS: Just calls DoCreateStream.
   void OnCreateStream(int stream_id,
                       int render_frame_id,
                       int session_id,
                       const AudioInputHostMsg_CreateStream_Config& config);
 
   // Creates an audio input stream with the specified format whose data is
   // consumed by an entity in the RenderFrame referenced by |render_frame_id|.
-  // |session_id| is used to find out which device to be used for the stream.
-  // Upon success/failure, the peer is notified via the
+  // |session_id| is used to identify the device that should be used for the
+  // stream. Upon success/failure, the peer is notified via the
   // NotifyStreamCreated message.
   void DoCreateStream(int stream_id,
                       int render_frame_id,
                       int session_id,
                       const AudioInputHostMsg_CreateStream_Config& config);
 
   // Record the audio input stream referenced by |stream_id|.
   void OnRecordStream(int stream_id);
 
   // Close the audio stream referenced by |stream_id|.
@@ skipping 14 matching lines @@
   void DoHandleError(media::AudioInputController* controller,
       media::AudioInputController::ErrorCode error_code);
 
   // Log audio level of captured audio stream.
   void DoLog(media::AudioInputController* controller,
              const std::string& message);
 
   // Send an error message to the renderer.
   void SendErrorMessage(int stream_id, ErrorCode error_code);
 
-  // Delete all audio entry and all audio streams
+  // Delete all audio entries and all audio streams.
   void DeleteEntries();
 
   // Closes the stream. The stream is then deleted in DeleteEntry() after it
   // is closed.
   void CloseAndDeleteStream(AudioEntry* entry);
 
   // Delete an audio entry and close the related audio stream.
   void DeleteEntry(AudioEntry* entry);
 
   // Delete audio entry and close the related audio input stream.
@@ skipping 44 matching lines @@
   AudioMirroringManager* audio_mirroring_manager_;
 
   // A map of stream IDs to audio sources.
   AudioEntryMap audio_entries_;
 
   // Raw pointer of the UserInputMonitor.
   media::UserInputMonitor* user_input_monitor_;
 
   std::unique_ptr<media::AudioLog> audio_log_;
 
-  base::WeakPtrFactory<AudioInputRendererHost> weak_factory_;
-
   DISALLOW_COPY_AND_ASSIGN(AudioInputRendererHost);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_MEDIA_AUDIO_INPUT_RENDERER_HOST_H_