Struct traits for gfx::Range and gfx::RangeF.

Struct traits for gfx::Range and gfx::RangeF.

This can be useful for serializing/deserializing ui::CompositionText, etc.

BUG=NONE

Committed: https://crrev.com/0c9234448950979bb56ec999d1a0773c819326d0
Cr-Commit-Position: refs/heads/master@{#435056}

[Hadi, 2016-11-28 15:30:28]

The CQ bit was checked by moshayedi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 15:30:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hadi, 2016-11-28 15:32:36]

moshayedi@chromium.org changed reviewers:
+ sadrul@chromium.org

[Hadi, 2016-11-28 15:32:37]

PTAL.

[commit-bot: I haz the power, 2016-11-28 18:23:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 18:23:29]

Dry run: This issue passed the CQ dry run.

[Hadi, 2016-11-28 21:37:37]

moshayedi@chromium.org changed reviewers:
+ rsesek@chromium.org, tsepez@chromium.org

[Hadi, 2016-11-28 21:37:37]

rsesek@ can you please review ui/gfx/range/*?
tsepez@ can you please review ui/gfx/range/mojo/*?

[Tom Sepez, 2016-11-28 21:50:25]

LGTM otherwise.

https://codereview.chromium.org/2531323002/diff/40001/ui/gfx/range/mojo/range...
File ui/gfx/range/mojo/range.mojom (right):

https://codereview.chromium.org/2531323002/diff/40001/ui/gfx/range/mojo/range...
ui/gfx/range/mojo/range.mojom:1: // Copyright 2016 The Chromium Authors. All
rights reserved.
Are we sure we don't have this same thing somewhere else?

[Robert Sesek, 2016-11-28 22:17:32]

https://codereview.chromium.org/2531323002/diff/40001/ui/gfx/range/mojo/range...
File ui/gfx/range/mojo/range.mojom (right):

https://codereview.chromium.org/2531323002/diff/40001/ui/gfx/range/mojo/range...
ui/gfx/range/mojo/range.mojom:1: // Copyright 2016 The Chromium Authors. All
rights reserved.
On 2016/11/28 21:50:25, Tom Sepez wrote:
> Are we sure we don't have this same thing somewhere else?

Don't think so:
https://cs.chromium.org/search/?q=range+file:mojom$&sq=package:chromium&type=cs

https://codereview.chromium.org/2531323002/diff/40001/ui/gfx/range/mojo/range...
File ui/gfx/range/mojo/range_struct_traits.h (right):

https://codereview.chromium.org/2531323002/diff/40001/ui/gfx/range/mojo/range...
ui/gfx/range/mojo/range_struct_traits.h:16: static int start(const gfx::Range&
r) { return r.start(); }
uint32_t instead of int?

[Hadi, 2016-11-28 22:34:35]

The CQ bit was checked by moshayedi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 22:35:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hadi, 2016-11-28 22:36:38]

https://codereview.chromium.org/2531323002/diff/40001/ui/gfx/range/mojo/range...
File ui/gfx/range/mojo/range_struct_traits.h (right):

https://codereview.chromium.org/2531323002/diff/40001/ui/gfx/range/mojo/range...
ui/gfx/range/mojo/range_struct_traits.h:16: static int start(const gfx::Range&
r) { return r.start(); }
On 2016/11/28 22:17:31, Robert Sesek wrote:
> uint32_t instead of int?

Done.

[Robert Sesek, 2016-11-28 23:11:12]

lgtm

[Hadi, 2016-11-28 23:16:43]

The CQ bit was unchecked by moshayedi@chromium.org

[Hadi, 2016-11-28 23:16:50]

The CQ bit was checked by moshayedi@chromium.org

[Hadi, 2016-11-28 23:16:50]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2531323002/#ps60001
(title: "Addressed feedback.")

[commit-bot: I haz the power, 2016-11-28 23:18:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 01:36:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 01:36:08]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Hadi, 2016-11-29 01:41:03]

sadrul@ can you please review ui/gfx/typemaps.gni?

On 2016/11/29 01:36:08, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sadrul, 2016-11-29 01:46:11]

lgtm

[Hadi, 2016-11-29 03:38:42]

The CQ bit was checked by moshayedi@chromium.org

[commit-bot: I haz the power, 2016-11-29 03:39:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 03:47:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 03:47:46]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Hadi, 2016-11-29 04:11:36]

moshayedi@chromium.org changed reviewers:
+ sky@chromium.org

[Hadi, 2016-11-29 04:11:37]

sky@ can you please review DEPS?

[sky, 2016-11-29 18:11:33]

LGTM

[Hadi, 2016-11-29 19:40:45]

The CQ bit was checked by moshayedi@chromium.org

[commit-bot: I haz the power, 2016-11-29 19:41:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 19:47:43]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480448445524270,
"parent_rev": "fe2acb0632bf8a090f57e78b81ad34ce4cb0fbd4", "commit_rev":
"1f957c4c86149d441e70bdf0a6c069601c83e23c"}

[commit-bot: I haz the power, 2016-11-29 19:48:37]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-29 19:50:23]

Description was changed from

==========
Struct traits for gfx::Range and gfx::RangeF.

This can be useful for serializing/deserializing ui::CompositionText, etc.

BUG=NONE
==========

to

==========
Struct traits for gfx::Range and gfx::RangeF.

This can be useful for serializing/deserializing ui::CompositionText, etc.

BUG=NONE

Committed: https://crrev.com/0c9234448950979bb56ec999d1a0773c819326d0
Cr-Commit-Position: refs/heads/master@{#435056}
==========

[commit-bot: I haz the power, 2016-11-29 19:50:24]

Patchset 4 (id:??) landed as
https://crrev.com/0c9234448950979bb56ec999d1a0773c819326d0
Cr-Commit-Position: refs/heads/master@{#435056}