Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: headless/lib/browser/headless_devtools_client_impl.cc

Issue 2531313002: Expose the full API for attaching devtools clients: (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: headless/lib/browser/headless_devtools_client_impl.cc
diff --git a/headless/lib/browser/headless_devtools_client_impl.cc b/headless/lib/browser/headless_devtools_client_impl.cc
index 318ab8543cea28eb4f2a0c85010532305e53963e..4d171e2e15f493f971e256cf6cca90f1f7390469 100644
--- a/headless/lib/browser/headless_devtools_client_impl.cc
+++ b/headless/lib/browser/headless_devtools_client_impl.cc
@@ -69,11 +69,22 @@ HeadlessDevToolsClientImpl::HeadlessDevToolsClientImpl()
HeadlessDevToolsClientImpl::~HeadlessDevToolsClientImpl() {}
-void HeadlessDevToolsClientImpl::AttachToHost(
+bool HeadlessDevToolsClientImpl::AttachToHost(
+ content::DevToolsAgentHost* agent_host) {
+ DCHECK(!agent_host_);
+ if (agent_host->AttachClient(this)) {
+ agent_host_ = agent_host;
+ return true;
+ } else {
Sami 2016/11/28 16:58:13 nit: Chromium doesn't use "else" after "return": h
tmarek 2016/11/29 10:14:58 Done.
+ return false;
+ }
+}
+
+void HeadlessDevToolsClientImpl::ForceAttachToHost(
content::DevToolsAgentHost* agent_host) {
DCHECK(!agent_host_);
agent_host_ = agent_host;
- agent_host_->AttachClient(this);
+ agent_host_->ForceAttachClient(this);
}
void HeadlessDevToolsClientImpl::DetachFromHost(

Powered by Google App Engine
This is Rietveld 408576698