Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: tests/compiler/dart2js/embedded_category_api_boundary_test.dart

Issue 2531303002: Decouple WorkItem from Compiler (Closed)
Patch Set: Updated cf. comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/compiler_helper.dart ('k') | tests/compiler/dart2js/exit_code_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/embedded_category_api_boundary_test.dart
diff --git a/tests/compiler/dart2js/embedded_category_api_boundary_test.dart b/tests/compiler/dart2js/embedded_category_api_boundary_test.dart
index 042bc37ac5b2f6eb4630476a499f61ab26704ca0..c6e391d5beb39bd951bb2f67ac39cb206414f71d 100644
--- a/tests/compiler/dart2js/embedded_category_api_boundary_test.dart
+++ b/tests/compiler/dart2js/embedded_category_api_boundary_test.dart
@@ -23,7 +23,8 @@ main() async {
}
});
asyncTest(() async {
- analyze(uriList, {}, checkResults: checkResults, mode: AnalysisMode.MAIN);
+ await analyze(uriList, {},
+ checkResults: checkResults, mode: AnalysisMode.MAIN);
});
}
@@ -42,6 +43,10 @@ bool checkResults(Compiler compiler, CollectingDiagnosticHandler handler) {
LibraryInfo info = libraries[element.library.canonicalUri.path];
bool isAllowedInEmbedded =
info.isInternal || info.categories.contains(Category.embedded);
+ if (!isAllowedInEmbedded) {
+ print(
+ 'Disallowed element: $element from ${element.library.canonicalUri}');
+ }
return isAllowedInEmbedded;
});
}
« no previous file with comments | « tests/compiler/dart2js/compiler_helper.dart ('k') | tests/compiler/dart2js/exit_code_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698