Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: pkg/compiler/lib/src/js_backend/enqueuer.dart

Issue 2531303002: Decouple WorkItem from Compiler (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/enqueuer.dart
diff --git a/pkg/compiler/lib/src/js_backend/enqueuer.dart b/pkg/compiler/lib/src/js_backend/enqueuer.dart
index ff783ac8e28758a6b68d1eccc4b4bff49110c0f2..c0b028c951ed01490cd7bf6f8e475e9f657e9650 100644
--- a/pkg/compiler/lib/src/js_backend/enqueuer.dart
+++ b/pkg/compiler/lib/src/js_backend/enqueuer.dart
@@ -114,7 +114,7 @@ class CodegenEnqueuer extends EnqueuerImpl {
throw new SpannableAssertionFailure(
element, "Codegen work list is closed. Trying to add $element");
}
- queue.add(new CodegenWorkItem(_compiler, element));
+ queue.add(new CodegenWorkItem(backend, element));
// TODO(sigmund): add other missing dependencies (internals, selectors
// enqueued after allocations).
_compiler.dumpInfoTask
@@ -447,7 +447,12 @@ class CodegenEnqueuer extends EnqueuerImpl {
do {
while (queue.isNotEmpty) {
// TODO(johnniwinther): Find an optimal process order.
- strategy.processWorkItem(f, queue.removeLast());
+ WorkItem work = queue.removeLast();
+ if (!isProcessed(work.element)) {
+ strategy.processWorkItem(f, work);
+ // TODO(johnniwinther): Register the processed element here. This
+ // is currently a side-effect of calling `work.run`.
+ }
}
List recents = recentClasses.toList(growable: false);
recentClasses.clear();

Powered by Google App Engine
This is Rietveld 408576698