Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2531303002: Decouple WorkItem from Compiler (Closed)

Created:
4 years ago by Johnni Winther
Modified:
4 years ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Decouple WorkItem from Compiler - Remove Compiler and Enqueuer arguments from WorkItem.run - Move show progress from WorkItem.run to Compiler.showXProgress methods - Move Compiler.analyzeElement to Resolution.computeWorldImpact - Move Compiler.analyze to ResolutionWorkItem Move Compiler.codegen to CodegenWorkItem R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/258ed14ae3b350f8a6ebfb1a0b2b424f28680ca9

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1248 lines, -1036 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 1 5 chunks +49 lines, -33 lines 0 comments Download
M pkg/compiler/lib/src/common/codegen.dart View 1 4 chunks +15 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/common/resolution.dart View 3 chunks +15 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/common/work.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 30 chunks +175 lines, -173 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 21 chunks +110 lines, -77 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 23 chunks +218 lines, -279 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_helpers.dart View 1 4 chunks +78 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_impact.dart View 1 6 chunks +383 lines, -320 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/enqueuer.dart View 1 13 chunks +30 lines, -39 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart View 1 6 chunks +15 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/type_variable_handler.dart View 1 4 chunks +21 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/impact_serialization.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/task.dart View 1 chunk +1 line, -7 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 2 chunks +7 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/universe/use.dart View 1 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 1 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_impact.dart View 1 3 chunks +22 lines, -0 lines 0 comments Download
M pkg/compiler/tool/perf.dart View 1 4 chunks +9 lines, -5 lines 0 comments Download
M pkg/dart2js_incremental/lib/caching_compiler.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 1 1 chunk +7 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/embedded_category_api_boundary_test.dart View 1 2 chunks +6 lines, -1 line 0 comments Download
M tests/compiler/dart2js/exit_code_test.dart View 6 chunks +42 lines, -11 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 1 2 chunks +8 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 1 2 chunks +4 lines, -1 line 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 1 2 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years ago (2016-11-28 14:55:03 UTC) #2
Harry Terkelsen
lgtm nice! https://codereview.chromium.org/2531303002/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/2531303002/diff/1/pkg/compiler/lib/src/compiler.dart#newcode937 pkg/compiler/lib/src/compiler.dart:937: /* delete commented code https://codereview.chromium.org/2531303002/diff/1/pkg/compiler/lib/src/compiler.dart#newcode2123 pkg/compiler/lib/src/compiler.dart:2123: assert(invariant(element, ...
4 years ago (2016-11-28 19:24:29 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as 258ed14ae3b350f8a6ebfb1a0b2b424f28680ca9 (presubmit successful).
4 years ago (2016-11-29 08:31:48 UTC) #5
Johnni Winther
4 years ago (2016-11-29 08:43:38 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2531303002/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/2531303002/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compiler.dart:937: /*
On 2016/11/28 19:24:29, Harry Terkelsen wrote:
> delete commented code

Done.

https://codereview.chromium.org/2531303002/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compiler.dart:2123: assert(invariant(element,
element.isDeclaration));
On 2016/11/28 19:24:29, Harry Terkelsen wrote:
> you have the same invariant twice

One removed!

Powered by Google App Engine
This is Rietveld 408576698