Abort CompositeEditCommand::moveParagraphs if destination is inside moving range

Abort CompositeEditCommand::moveParagraphs if destination is inside moving range

This patch makes CompositeEditCommand::moveParagraphs abort in the above
mentioned case, because there is no way to move the contents to a destination
inside itself.

There might be a deeper cause of passing such invalid parameter combination
to the function, which is not covered by this patch.

BUG=585048
TEST=webkit_unit_tests --gtest_filter=TypingCommandTest.insertLineBreakWithIllFormedHTML

Committed: https://crrev.com/3e1ec97972c1e09d8e472aad4cf225d1ffc5dfef
Cr-Commit-Position: refs/heads/master@{#434844}

[Xiaocheng, 2016-11-28 13:08:13]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 13:08:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-11-28 13:12:18]

Description was changed from

==========
Abort CompositeEditCommand::moveParagraphs if destination is inside moving range

BUG=585048
==========

to

==========
Abort CompositeEditCommand::moveParagraphs if destination is inside moving range

BUG=585048
TEST=webkit_unit_tests
--gtest_filter=TypingCommandTest.insertLineBreakWithIllFormedHTML
==========

[Xiaocheng, 2016-11-28 13:14:47]

Description was changed from

==========
Abort CompositeEditCommand::moveParagraphs if destination is inside moving range

BUG=585048
TEST=webkit_unit_tests
--gtest_filter=TypingCommandTest.insertLineBreakWithIllFormedHTML
==========

to

==========
Abort CompositeEditCommand::moveParagraphs if destination is inside moving range

This patch makes CompositeEditCommand::moveParagraphs abort in the above
mentioned case, because there is no way to move the contents to a destination
inside itself.

There might be a deeper cause of passing such invalid parameter combination
to the function, which is not covered by this patch.

BUG=585048
TEST=webkit_unit_tests
--gtest_filter=TypingCommandTest.insertLineBreakWithIllFormedHTML
==========

[commit-bot: I haz the power, 2016-11-28 16:52:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 16:52:50]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-11-28 17:05:01]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-11-28 17:05:02]

PTAL

[yosin_UTC9, 2016-11-29 01:31:32]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2016-11-29 01:31:33]

lgtm

We'll study root cause when we revise visible position canonicalization.


+tken@ for core/BUILD.gn to add TypingCommandTest.cpp

[tkent, 2016-11-29 01:33:23]

lgtm

[Xiaocheng, 2016-11-29 01:37:28]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-11-29 01:38:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 02:50:17]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480383448318080, "parent_rev":
"3d407f87ae2320024b3c9ae93fde970529731500", "commit_rev":
"1c1328dbf2c5d809951aadd51419765e488d54bc"}

[commit-bot: I haz the power, 2016-11-29 02:50:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-29 02:53:35]

Description was changed from

==========
Abort CompositeEditCommand::moveParagraphs if destination is inside moving range

This patch makes CompositeEditCommand::moveParagraphs abort in the above
mentioned case, because there is no way to move the contents to a destination
inside itself.

There might be a deeper cause of passing such invalid parameter combination
to the function, which is not covered by this patch.

BUG=585048
TEST=webkit_unit_tests
--gtest_filter=TypingCommandTest.insertLineBreakWithIllFormedHTML
==========

to

==========
Abort CompositeEditCommand::moveParagraphs if destination is inside moving range

This patch makes CompositeEditCommand::moveParagraphs abort in the above
mentioned case, because there is no way to move the contents to a destination
inside itself.

There might be a deeper cause of passing such invalid parameter combination
to the function, which is not covered by this patch.

BUG=585048
TEST=webkit_unit_tests
--gtest_filter=TypingCommandTest.insertLineBreakWithIllFormedHTML

Committed: https://crrev.com/3e1ec97972c1e09d8e472aad4cf225d1ffc5dfef
Cr-Commit-Position: refs/heads/master@{#434844}
==========

[commit-bot: I haz the power, 2016-11-29 02:53:36]

Patchset 1 (id:??) landed as
https://crrev.com/3e1ec97972c1e09d8e472aad4cf225d1ffc5dfef
Cr-Commit-Position: refs/heads/master@{#434844}