third_party/WebKit/Source/core/html/parser/XSSAuditorDelegate.cpp - Issue 2531253002: Fix a potential null deref in XSSAuditorDelegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/XSSAuditorDelegate.cpp

Issue 2531253002: Fix a potential null deref in XSSAuditorDelegate. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/parser/XSSAuditorDelegate.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/XSSAuditorDelegate.cpp b/third_party/WebKit/Source/core/html/parser/XSSAuditorDelegate.cpp

index 9590e48c93a62c02d61871303b61e3e59662dab7..cb7f26393261ca544ed8706aebe3d7f660e7f65f 100644

--- a/third_party/WebKit/Source/core/html/parser/XSSAuditorDelegate.cpp

+++ b/third_party/WebKit/Source/core/html/parser/XSSAuditorDelegate.cpp

@@ -115,7 +115,7 @@ void XSSAuditorDelegate::didBlockScript(const XSSInfo& xssInfo) {

if (xssInfo.m_didBlockEntirePage)

frameLoader.stopAllLoaders();

- if (!m_didSendNotifications) {

+ if (!m_didSendNotifications && frameLoader.client()) {

m_didSendNotifications = true;

frameLoader.client()->didDetectXSS(m_document->url(),

« no previous file with comments | « no previous file | no next file » | no next file with comments »