components/autofill/core/browser/autofill_manager.h - Issue 2531223003: Expanded Autofill Credit Card Popup Layout Experiment in Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_manager.h

Issue 2531223003: Expanded Autofill Credit Card Popup Layout Experiment in Android. (Closed)

Patch Set: Uses format string for expiration date label. Consistently returns 0 as default (non-experiment) va… Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/core/browser/autofill_manager.h

diff --git a/components/autofill/core/browser/autofill_manager.h b/components/autofill/core/browser/autofill_manager.h

index f3d3e2f762e8271d3fc262f0cda24476164aef63..2271dc583e0879afc61b20425ef9754b4b14e9ef 100644

--- a/components/autofill/core/browser/autofill_manager.h

+++ b/components/autofill/core/browser/autofill_manager.h

@@ -97,6 +97,10 @@ class AutofillManager : public AutofillDownloadManager::Observer,

virtual bool ShouldShowScanCreditCard(const FormData& form,

const FormFieldData& field);

Mathieu 2016/12/01 21:59:47 // Whether the |field| belongs to the CREDIT_CARD

csashi 2016/12/02 05:15:29 Done.

+ virtual bool IsCreditCardField(const FormData& form,

+ const FormFieldData& field);

// Whether we should show the signin promo, based on the triggered |field|

// inside the |form|.

virtual bool ShouldShowCreditCardSigninPromo(const FormData& form,