chrome/browser/ui/autofill/autofill_popup_controller_impl.cc - Issue 2531223003: Expanded Autofill Credit Card Popup Layout Experiment in Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

Issue 2531223003: Expanded Autofill Credit Card Popup Layout Experiment in Android. (Closed)

Patch Set: Uses format string for expiration date label. Consistently returns 0 as default (non-experiment) va… Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

index 7cdca6c774095b94854d878f2f4ce81c36948e75..9dcd4b2ee5f97d55de074c91e8978fb66f73b816 100644

--- a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

+++ b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

@@ -70,7 +70,7 @@ AutofillPopupControllerImpl::AutofillPopupControllerImpl(

container_view,

web_contents)),

view_(NULL),

- layout_model_(this),

+ layout_model_(this, delegate->IsCreditCardField()),

Mathieu 2016/12/01 21:59:46 as mentioned, would prefer IsCreditCardPopup to ma

csashi 2016/12/02 05:15:29 Done.

delegate_(delegate),

weak_ptr_factory_(this) {

ClearState();