chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java - Issue 2531223003: Expanded Autofill Credit Card Popup Layout Experiment in Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java

Issue 2531223003: Expanded Autofill Credit Card Popup Layout Experiment in Android. (Closed)

Patch Set: Uses format string for expiration date label. Consistently returns 0 as default (non-experiment) va… Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwAutofillClient.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java » ('j') | chrome/browser/ui/autofill/autofill_popup_controller_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java

index a01f2f75f4711b65791ed848f977375b2263d4e1..875f941fdb5420ead6f3382d6dd4bb7e7434b33f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java

@@ -149,8 +149,8 @@ public class AutofillKeyboardAccessoryBridge

private static void addToAutofillSuggestionArray(AutofillSuggestion[] array, int index,

String label, String sublabel, int iconId, int suggestionId, boolean deletable) {

int drawableId = iconId == 0 ? DropdownItem.NO_ICON : ResourceId.mapToDrawableId(iconId);

- array[index] =

- new AutofillSuggestion(label, sublabel, drawableId, suggestionId, deletable, false);

+ array[index] = new AutofillSuggestion(label, sublabel, drawableId, suggestionId, deletable,

+ false /* isMultilineLabel */, false /* isBoldLabel */);

}

private native void nativeViewDismissed(long nativeAutofillKeyboardAccessoryView);