Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

Issue 2531223003: Expanded Autofill Credit Card Popup Layout Experiment in Android. (Closed)
Patch Set: Fixes compile error. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
diff --git a/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc b/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
index 3046b58dee981cf97273826b3b7ac490622061c7..6795ac78bb65f28ad16d2cae3c4fc9a4be12fc23 100644
--- a/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
+++ b/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
@@ -94,7 +94,7 @@ void AutofillPopupViewAndroid::UpdateBoundsAndRedrawPopup() {
controller_->layout_model().GetIconResourceID(suggestion.icon));
}
- bool deletable =
+ bool is_deletable =
controller_->GetRemovalConfirmationText(i, nullptr, nullptr);
bool is_label_multiline =
suggestion.frontend_id ==
@@ -102,11 +102,16 @@ void AutofillPopupViewAndroid::UpdateBoundsAndRedrawPopup() {
suggestion.frontend_id == POPUP_ITEM_ID_CREDIT_CARD_SIGNIN_PROMO;
Java_AutofillPopupBridge_addToAutofillSuggestionArray(
env, data_array, i, value, label, android_icon_id,
- suggestion.frontend_id, deletable, is_label_multiline);
+ controller_->layout_model().IsIconAtStart(suggestion.frontend_id),
+ suggestion.frontend_id, is_deletable, is_label_multiline,
+ suggestion.is_value_bold);
}
- Java_AutofillPopupBridge_show(env, java_object_, data_array,
- controller_->IsRTL());
+ Java_AutofillPopupBridge_show(
+ env, java_object_, data_array, controller_->IsRTL(),
+ controller_->layout_model().GetBackgroundColor(),
+ controller_->layout_model().GetDividerColor(),
+ controller_->layout_model().GetDropdownItemHeight());
}
void AutofillPopupViewAndroid::SuggestionSelected(

Powered by Google App Engine
This is Rietveld 408576698