Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2121)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java

Issue 2531223003: Expanded Autofill Credit Card Popup Layout Experiment in Android. (Closed)
Patch Set: Fixes compile error. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java
index 8266579e627fd955cb7a3fc6b8a88efb263ba1e4..b5adb64387e022e6d4b4b8f0eeb9b12a27897614 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java
@@ -92,10 +92,19 @@ public class AutofillPopupBridge implements AutofillDelegate, DialogInterface.On
/**
* Shows an Autofill popup with specified suggestions.
* @param suggestions Autofill suggestions to be displayed.
+ * @param isRtl @code true if right-to-left text.
+ * @param backgroundColor popup background color, or {@code Color.TRANSPARENT} if not specified
+ * in experiment.
+ * @param dividerColor color for divider between popup items, or {@code Color.TRANSPARENT} if
+ * not specified in experiment.
+ * @param dropdownItemHeight height of each dropdown item in dimension independent pixel units,
+ * 0 if not specified in experiment.
*/
@CalledByNative
- private void show(AutofillSuggestion[] suggestions, boolean isRtl) {
- if (mAutofillPopup != null) mAutofillPopup.filterAndShow(suggestions, isRtl);
+ private void show(AutofillSuggestion[] suggestions, boolean isRtl, int backgroundColor,
+ int dividerColor, int dropdownItemHeight) {
+ if (mAutofillPopup != null) mAutofillPopup.filterAndShow(suggestions, isRtl,
+ backgroundColor, dividerColor, dropdownItemHeight);
}
@CalledByNative
@@ -122,17 +131,20 @@ public class AutofillPopupBridge implements AutofillDelegate, DialogInterface.On
* @param label First line of the suggestion.
* @param sublabel Second line of the suggestion.
* @param iconId The resource ID for the icon associated with the suggestion, or 0 for no icon.
+ * @param isIconAtStart {@code true} if {@param iconId} is displayed before {@param label}.
* @param suggestionId Identifier for the suggestion type.
- * @param deletable Whether this item is deletable.
+ * @param isDeletable Whether the item can be deleted by the user.
* @param isLabelMultiline Whether the label should be should over multiple lines.
+ * @param isLabelBold true if {@param label} should be displayed in {@code Typeface.BOLD},
+ * false if {@param label} should be displayed in {@code Typeface.NORMAL}.
*/
@CalledByNative
private static void addToAutofillSuggestionArray(AutofillSuggestion[] array, int index,
- String label, String sublabel, int iconId, int suggestionId, boolean deletable,
- boolean isLabelMultiline) {
+ String label, String sublabel, int iconId, boolean isIconAtStart,
+ int suggestionId, boolean isDeletable, boolean isLabelMultiline, boolean isLabelBold) {
int drawableId = iconId == 0 ? DropdownItem.NO_ICON : ResourceId.mapToDrawableId(iconId);
- array[index] = new AutofillSuggestion(
- label, sublabel, drawableId, suggestionId, deletable, isLabelMultiline);
+ array[index] = new AutofillSuggestion(label, sublabel, drawableId, isIconAtStart,
+ suggestionId, isDeletable, isLabelMultiline, isLabelBold);
}
private native void nativeSuggestionSelected(long nativeAutofillPopupViewAndroid,

Powered by Google App Engine
This is Rietveld 408576698