content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDropdown.java - Issue 2531223003: Expanded Autofill Credit Card Popup Layout Experiment in Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDropdown.java

Issue 2531223003: Expanded Autofill Credit Card Popup Layout Experiment in Android. (Closed)

Patch Set: Adds clarifying comments for DropdownAdapter parameters. Moves checking whether icon should be at s… Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_autofill_manager.cc ('k') | ui/android/java/res/layout/dropdown_item.xml » ('j') | ui/android/java/src/org/chromium/ui/DropdownAdapter.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDropdown.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDropdown.java b/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDropdown.java

index b9437f0956fb78b70bd2e51ac8de8effe1943407..cc03f17ef806fc26d145eb825eeb262aebd7bd6f 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDropdown.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDropdown.java

@@ -5,6 +5,7 @@

package org.chromium.content.browser.input;

import android.content.Context;

+import android.graphics.Color;

import android.view.View;

import android.widget.AdapterView;

import android.widget.PopupWindow;

@@ -44,7 +45,9 @@ public class SelectPopupDropdown implements SelectPopup {

initialSelection = selected[0];

}

mDropdownPopupWindow.setInitialSelection(initialSelection);

- mDropdownPopupWindow.setAdapter(new DropdownAdapter(mContext, items, null));

+ mDropdownPopupWindow.setAdapter(new DropdownAdapter(

+ mContext, items, null /* separators */, Color.TRANSPARENT /* backgroundColor */,

+ Color.TRANSPARENT /* dividerColor */, 0 /* dropdownItemHeight */));

mDropdownPopupWindow.setRtl(rightAligned);

mDropdownPopupWindow.setOnDismissListener(

new PopupWindow.OnDismissListener() {