Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2583)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwAutofillClient.java

Issue 2531223003: Expanded Autofill Credit Card Popup Layout Experiment in Android. (Closed)
Patch Set: Adds clarifying comments for DropdownAdapter parameters. Moves checking whether icon should be at s… Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/AwAutofillClient.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwAutofillClient.java b/android_webview/java/src/org/chromium/android_webview/AwAutofillClient.java
index 65781e42e02e64cfd4f8451c9fcd6e01dd023857..061dafe874ffb11f4520b55b61fa6bc39be6484c 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwAutofillClient.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwAutofillClient.java
@@ -4,6 +4,7 @@
package org.chromium.android_webview;
+import android.graphics.Color;
import android.view.View;
import android.view.ViewGroup;
@@ -64,7 +65,9 @@ public class AwAutofillClient {
public void deleteSuggestion(int listIndex) { }
});
}
- mAutofillPopup.filterAndShow(suggestions, isRtl);
+ mAutofillPopup.filterAndShow(suggestions, isRtl, Color.TRANSPARENT /* backgroundColor */,
+ Color.TRANSPARENT /* dividerColor */, 0 /* dropdownItemHeight */,
+ false /* isIconAtStart */);
}
@CalledByNative
@@ -89,8 +92,9 @@ public class AwAutofillClient {
@CalledByNative
private static void addToAutofillSuggestionArray(AutofillSuggestion[] array, int index,
String name, String label, int uniqueId) {
- array[index] =
- new AutofillSuggestion(name, label, DropdownItem.NO_ICON, uniqueId, false, false);
+ array[index] = new AutofillSuggestion(name, label, DropdownItem.NO_ICON,
+ false /* isIconAtLeft */, uniqueId, false /* isDeletable */,
+ false /* isMultilineLabel */, false /* isBoldLabel */);
}
private native void nativeDismissed(long nativeAwAutofillClient);

Powered by Google App Engine
This is Rietveld 408576698