Expanded Autofill Credit Card Popup Layout Experiment in Android.

chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

Index: chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
diff --git a/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc b/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
index 3046b58dee981cf97273826b3b7ac490622061c7..b59eb3c14eb2d8d2a3c9e218d03ba0b827d05c6b 100644
--- a/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
+++ b/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
@@ -94,7 +94,7 @@ void AutofillPopupViewAndroid::UpdateBoundsAndRedrawPopup() {
           controller_->layout_model().GetIconResourceID(suggestion.icon));
     }
 
-    bool deletable =
+    bool is_deletable =
         controller_->GetRemovalConfirmationText(i, nullptr, nullptr);
     bool is_label_multiline =
         suggestion.frontend_id ==
@@ -102,11 +102,16 @@ void AutofillPopupViewAndroid::UpdateBoundsAndRedrawPopup() {
         suggestion.frontend_id == POPUP_ITEM_ID_CREDIT_CARD_SIGNIN_PROMO;
     Java_AutofillPopupBridge_addToAutofillSuggestionArray(
         env, data_array, i, value, label, android_icon_id,
-        suggestion.frontend_id, deletable, is_label_multiline);
+        controller_->layout_model().IsIconAtStart(),

[Mathieu, 2016/12/08 18:35:10]

Can you pass |suggestion_id| to ..LayoutModel::IsIconAtStart, that way we can
remove the check in AutofillSuggestion.isIconAtStart that checks about the HTTP
ITEM_ID_HTTP_NOT_SECURE_WARNING_MESSAGE and rather have it in the layout model.

[csashi, 2016/12/08 20:09:01]

Done.

+        suggestion.frontend_id, is_deletable, is_label_multiline,
+        suggestion.is_value_bold);
   }
 
-  Java_AutofillPopupBridge_show(env, java_object_, data_array,
-                                controller_->IsRTL());
+  Java_AutofillPopupBridge_show(
+      env, java_object_, data_array, controller_->IsRTL(),
+      controller_->layout_model().GetBackgroundColor(),
+      controller_->layout_model().GetDividerColor(),
+      controller_->layout_model().GetDropdownItemHeight());
 }
 
 void AutofillPopupViewAndroid::SuggestionSelected(