ui/android/java/res/layout/dropdown_item_icon_at_left.xml - Issue 2531223003: Expanded Autofill Credit Card Popup Layout Experiment in Android.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/android/java/res/layout/dropdown_item_icon_at_left.xml

Issue 2531223003: Expanded Autofill Credit Card Popup Layout Experiment in Android. (Closed)

Patch Set: Uses format string for expiration date label. Consistently returns 0 as default (non-experiment) va… Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/autofill/core/browser/autofill_manager.h ('K') | « content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDropdown.java ('k') | ui/android/java/res/values/colors.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>
	Mathieu 2016/12/01 21:59:47 Can you look at the discussion here [1] and see wh Can you look at the discussion here [1] and see whether it applies, about creating a separate XML file just for the left icon? https://codereview.chromium.org/2510283002/#msg15 csashi 2016/12/02 05:15:29 Yes, it applies. I have modified my CL to be simil Show quoted text On 2016/12/01 21:59:47, Mathieu Perreault wrote: > Can you look at the discussion here [1] and see whether it applies, about > creating a separate XML file just for the left icon? > > https://codereview.chromium.org/2510283002/#msg15 Yes, it applies. I have modified my CL to be similar to this change.
	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

	3

	4 Use of this source code is governed by a BSD-style license that can be

	5 found in the LICENSE file.

	6 -->

	7

	8 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

	9 android:layout_width="match_parent"

	10 android:layout_height="wrap_content"

	11 android:gravity="center_vertical"

	12 android:orientation="horizontal" >

	13

	14 <ImageView

	15 android:id="@+id/dropdown_icon"

	16 android:layout_width="wrap_content"

	17 android:layout_height="wrap_content"

	18 android:layout_margin="8dp"

	19 android:contentDescription="@null" />

	20

	21 <!-- These layout params are overwritten in DropdownAdapter.java -->

	22

	23 <LinearLayout

	24 android:id="@+id/dropdown_label_wrapper"

	25 android:layout_width="0dp"

	26 android:layout_height="0dp"

	27 android:layout_weight="1"

	28 android:gravity="center_vertical"

	29 android:orientation="vertical" >

	30

	31 <TextView

	32 android:id="@+id/dropdown_label"

	33 android:layout_width="wrap_content"

	34 android:layout_height="wrap_content"

	35 android:layout_marginEnd="10dp"

	36 android:layout_marginStart="10dp"

	37 android:ellipsize="end"

	38 android:includeFontPadding="false"

	39 android:singleLine="true"

	40 android:textAlignment="viewStart"

	41 android:textColor="@drawable/dropdown_label_color"

	42 android:textSize="@dimen/dropdown_item_label_font_size" />

	43

	44 <TextView

	45 android:id="@+id/dropdown_sublabel"

	46 android:layout_width="wrap_content"

	47 android:layout_height="wrap_content"

	48 android:layout_marginEnd="10dp"

	49 android:layout_marginStart="10dp"

	50 android:ellipsize="end"

	51 android:includeFontPadding="false"

	52 android:singleLine="true"

	53 android:textAlignment="viewStart"

	54 android:textColor="#646464"

	55 android:textSize="14sp" />

	56 </LinearLayout>

	57

	58 </LinearLayout>

OLD	NEW