Expanded Autofill Credit Card Popup Layout Experiment in Android.

components/autofill/core/browser/autofill_external_delegate.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXTERNAL_DELEGATE_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXTERNAL_DELEGATE_H_
 
 #include <vector>
 
 #include "base/compiler_specific.h"
@@ skipping 33 matching lines @@
                            int identifier) override;
   void DidAcceptSuggestion(const base::string16& value,
                            int identifier,
                            int position) override;
   bool GetDeletionConfirmationText(const base::string16& value,
                                    int identifier,
                                    base::string16* title,
                                    base::string16* body) override;
   bool RemoveSuggestion(const base::string16& value, int identifier) override;
   void ClearPreviewedForm() override;
+  // Returns false for all fields prior to |onQuery|, true for credit card
+  // fields after call to |onQuery|.
+  bool IsCreditCardField() override;
 
   // Records and associates a query_id with web form data.  Called
   // when the renderer posts an Autofill query to the browser. |bounds|
   // is window relative. We might not want to display the warning if a website
   // has disabled Autocomplete because they have their own popup, and showing
   // our popup on to of theirs would be a poor user experience.
   virtual void OnQuery(int query_id,
                        const FormData& form,
                        const FormFieldData& field,
                        const gfx::RectF& element_bounds);
@@ skipping 47 matching lines @@
   // This function should only get called when there is at least one
   // multi-field suggestion in the list of suggestions.
   void ApplyAutofillOptions(std::vector<Suggestion>* suggestions);
 
   // Insert the data list values at the start of the given list, including
   // any required separators. Will also go through |suggestions| and remove
   // duplicate autocomplete (not Autofill) suggestions, keeping their datalist
   // version.
   void InsertDataListValues(std::vector<Suggestion>* suggestions);
 
+  // Returns the text (i.e. |Suggestion| value) for Chrome autofill options.
+  base::string16 GetSettingsSuggestionValue() const;
+
   AutofillManager* manager_;  // weak.
 
   // Provides driver-level context to the shared code of the component. Must
   // outlive this object.
   AutofillDriver* driver_;  // weak
 
   // The ID of the last request sent for form field Autofill.  Used to ignore
   // out of date responses.
   int query_id_;
 
   // The current form and field selected by Autofill.
   FormData query_form_;
   FormFieldData query_field_;
 
   // The bounds of the form field that user is interacting with.
   gfx::RectF element_bounds_;
 
   // Does the popup include any Autofill profile or credit card suggestions?
   bool has_autofill_suggestions_;
 
   // Have we already shown Autofill suggestions for the field the user is
   // currently editing?  Used to keep track of state for metrics logging.
   bool has_shown_popup_for_current_edit_;
 
   // FIXME

[Mathieu, 2016/12/01 21:59:47]

unclear why this is here?

[csashi, 2016/12/02 05:15:29]

By "this", do you mean the "FIXME" or the "is_credit_card_field_"? The
"is_credit_card_field" is here so we can show the current settings text in
ApplyAutofillOptions. By default we will show "Chrome Autofill Settings". In an
experiment, we can try replacing with "Add or Remove Cards.

I have removed the FIXME.

   bool should_show_scan_credit_card_;
+  bool is_credit_card_field_;
 
   // Whether the credit card signin promo should be shown to the user.
   bool should_show_cc_signin_promo_;
 
   // Whether the access Address Book prompt has ever been shown for the current
   // |query_form_|. This variable is only used on OSX.
   bool has_shown_address_book_prompt;
 
   // The current data list values.
   std::vector<base::string16> data_list_values_;
   std::vector<base::string16> data_list_labels_;
 
   base::WeakPtrFactory<AutofillExternalDelegate> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillExternalDelegate);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXTERNAL_DELEGATE_H_