Expanded Autofill Credit Card Popup Layout Experiment in Android.

chrome/browser/ui/autofill/autofill_popup_layout_model.cc

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/autofill_popup_layout_model.h"
 
 #include <algorithm>
 
 #include "base/macros.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ui/autofill/autofill_popup_view.h"
 #include "chrome/browser/ui/autofill/popup_constants.h"
+#include "components/autofill/core/browser/autofill_experiments.h"
 #include "components/autofill/core/browser/popup_item_ids.h"
 #include "components/autofill/core/browser/suggestion.h"
 #include "components/autofill/core/common/autofill_util.h"
 #include "components/grit/components_scaled_resources.h"
+#include "third_party/skia/include/core/SkColor.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/color_palette.h"
 #include "ui/gfx/font_list.h"
 #include "ui/gfx/geometry/rect_conversions.h"
 
 namespace autofill {
 
 namespace {
 
 // The vertical height of each row in pixels.
@@ skipping 27 matching lines @@
 int GetRowHeightFromId(int identifier) {
   if (identifier == POPUP_ITEM_ID_SEPARATOR)
     return kSeparatorHeight;
 
   return kRowHeight;
 }
 
 }  // namespace
 
 AutofillPopupLayoutModel::AutofillPopupLayoutModel(
-    AutofillPopupViewDelegate* delegate)
-    : delegate_(delegate) {
+    AutofillPopupViewDelegate* delegate, bool is_credit_card_popup)
+    : delegate_(delegate), is_credit_card_popup_(is_credit_card_popup) {
 #if !defined(OS_ANDROID)
   smaller_font_list_ =
       normal_font_list_.DeriveWithSizeDelta(kSmallerFontSizeDelta);
   bold_font_list_ = normal_font_list_.DeriveWithWeight(gfx::Font::Weight::BOLD);
 #if defined(OS_MACOSX)
   // There is no italic version of the system font.
   warning_font_list_ = normal_font_list_;
 #else
   warning_font_list_ = normal_font_list_.DeriveWithStyle(gfx::Font::ITALIC);
 #endif
@@ skipping 161 matching lines @@
     result = IDR_AUTOFILL_CC_SCAN_NEW_KEYBOARD_ACCESSORY;
 #endif
 
   return result;
 }
 
 const gfx::Rect AutofillPopupLayoutModel::RoundedElementBounds() const {
   return gfx::ToEnclosingRect(delegate_->element_bounds());
 }
 
+bool AutofillPopupLayoutModel::IsPopupLayoutExperimentEnabled() const {
+  return is_credit_card_popup_ &&
+      IsAutofillCreditCardPopupLayoutExperimentEnabled();
+}
+
+SkColor AutofillPopupLayoutModel::GetBackgroundColor() const {
+  return is_credit_card_popup_ ?
+      GetCreditCardPopupBackgroundColor() : SK_ColorTRANSPARENT;

[Ilya Sherman, 2016/12/03 00:02:18]

Should this be checking for IsPopupLayoutExperimentEnabled() rather than
is_credit_card_popup_?  I think there's currently an implicit assumption that
the 0 returned from GetCreditCardPopupBackgroundColor() is equivalent to
SK_ColorTRANSPARENT... which might be true, but is not obvious to, say, me.

[csashi, 2016/12/03 00:40:07]

GetCreditCardPopupBackgroundColor checks if the popup experiment is enabled.

I have clarified that the 0 returned from the functions is chosen because it
maps to SK_ColorTRANSPARENT.

+}
+
+SkColor AutofillPopupLayoutModel::GetDividerColor() const {
+  return is_credit_card_popup_ ?
+      GetCreditCardPopupDividerColor() : SK_ColorTRANSPARENT;
+}
+
+unsigned int AutofillPopupLayoutModel::GetDropdownItemHeight() const {
+  return is_credit_card_popup_ ? GetCreditCardPopupDropdownItemHeight() : 0;
+}
+
+bool AutofillPopupLayoutModel::IsIconAtStart() const {
+  return is_credit_card_popup_ && IsCreditCardIconInPopupAtStart();
+}
+
 }  // namespace autofill