Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2531183003: Revert of [turbofan] Utilize String comparison feedback. (Closed)

Created:
4 years ago by rmcilroy
Modified:
4 years ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Utilize String comparison feedback. (patchset #1 id:1 of https://codereview.chromium.org/2523463002/ ) Reason for revert: Seems to regress speedometer on Ignition and doesn't cause any improvements elsewhere. BUG=chromium:668651 Original issue's description: > [turbofan] Utilize String comparison feedback. > > Make use of the previously introduced String feedback for compare > operations in TurboFan. > > R=jarin@chromium.org > BUG=v8:5267, v8:5400 > > Committed: https://crrev.com/5d4253ecfb6ddcbbd7eb5654e728efa9559284a2 > Cr-Commit-Position: refs/heads/master@{#41163} TBR=jarin@chromium.org,bmeurer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5267, v8:5400 Committed: https://crrev.com/12d821dd686d48da6e0f678699ac223fa4b29ea9 Cr-Commit-Position: refs/heads/master@{#41324}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -41 lines) Patch
M src/compiler/js-typed-lowering.cc View 6 chunks +0 lines, -41 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
rmcilroy
Created Revert of [turbofan] Utilize String comparison feedback.
4 years ago (2016-11-28 16:50:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2531183003/1
4 years ago (2016-11-28 16:50:39 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 17:15:18 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/12d821dd686d48da6e0f678699ac223fa4b29ea9 Cr-Commit-Position: refs/heads/master@{#41324}
4 years ago (2016-11-28 17:15:28 UTC) #8
Benedikt Meurer
4 years ago (2016-11-28 18:02:42 UTC) #9
Message was sent while issue was closed.
LGTM, thanks.

Powered by Google App Engine
This is Rietveld 408576698