Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: net/quic/core/quic_sent_packet_manager.cc

Issue 2531163009: Move QuicAckListenerInterface, QuicPendingRetransmission, and QuicTransmissionInfo out of quic_pack… (Closed)
Patch Set: Move QuicAckListenerInterface, QuicPendingRetransmission, and QuicTransmissionInfo out of quic_pack… Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_sent_packet_manager.h ('k') | net/quic/core/quic_sent_packet_manager_interface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_sent_packet_manager.cc
diff --git a/net/quic/core/quic_sent_packet_manager.cc b/net/quic/core/quic_sent_packet_manager.cc
index 1732f4a98f776c9b294a93c4547977ed0fdab278..1e69384b9b58c3eb720b4e96ab0611c560813ef2 100644
--- a/net/quic/core/quic_sent_packet_manager.cc
+++ b/net/quic/core/quic_sent_packet_manager.cc
@@ -45,7 +45,7 @@ static const int64_t kConservativeMinHandshakeTimeoutMs = kMaxDelayedAckTimeMs;
// per draft RFC draft-dukkipati-tcpm-tcp-loss-probe.
static const size_t kDefaultMaxTailLossProbes = 2;
-bool HasCryptoHandshake(const TransmissionInfo& transmission_info) {
+bool HasCryptoHandshake(const QuicTransmissionInfo& transmission_info) {
DCHECK(!transmission_info.has_crypto_handshake ||
!transmission_info.retransmittable_frames.empty());
return transmission_info.has_crypto_handshake;
@@ -404,7 +404,7 @@ void QuicSentPacketManager::NeuterUnencryptedPackets() {
void QuicSentPacketManager::MarkForRetransmission(
QuicPacketNumber packet_number,
TransmissionType transmission_type) {
- const TransmissionInfo& transmission_info =
+ const QuicTransmissionInfo& transmission_info =
unacked_packets_.GetTransmissionInfo(packet_number);
QUIC_BUG_IF(transmission_info.retransmittable_frames.empty());
// Both TLP and the new RTO leave the packets in flight and let the loss
@@ -428,7 +428,7 @@ void QuicSentPacketManager::MarkForRetransmission(
}
void QuicSentPacketManager::RecordOneSpuriousRetransmission(
- const TransmissionInfo& info) {
+ const QuicTransmissionInfo& info) {
stats_->bytes_spuriously_retransmitted += info.bytes_sent;
++stats_->packets_spuriously_retransmitted;
if (debug_delegate_ != nullptr) {
@@ -438,11 +438,11 @@ void QuicSentPacketManager::RecordOneSpuriousRetransmission(
}
void QuicSentPacketManager::RecordSpuriousRetransmissions(
- const TransmissionInfo& info,
+ const QuicTransmissionInfo& info,
QuicPacketNumber acked_packet_number) {
QuicPacketNumber retransmission = info.retransmission;
while (retransmission != 0) {
- const TransmissionInfo& retransmit_info =
+ const QuicTransmissionInfo& retransmit_info =
unacked_packets_.GetTransmissionInfo(retransmission);
retransmission = retransmit_info.retransmission;
RecordOneSpuriousRetransmission(retransmit_info);
@@ -459,7 +459,7 @@ bool QuicSentPacketManager::HasPendingRetransmissions() const {
return !pending_retransmissions_.empty();
}
-PendingRetransmission QuicSentPacketManager::NextPendingRetransmission() {
+QuicPendingRetransmission QuicSentPacketManager::NextPendingRetransmission() {
QUIC_BUG_IF(pending_retransmissions_.empty())
<< "Unexpected call to PendingRetransmissions() with empty pending "
<< "retransmission list. Corrupted memory usage imminent.";
@@ -477,21 +477,21 @@ PendingRetransmission QuicSentPacketManager::NextPendingRetransmission() {
}
}
DCHECK(unacked_packets_.IsUnacked(packet_number)) << packet_number;
- const TransmissionInfo& transmission_info =
+ const QuicTransmissionInfo& transmission_info =
unacked_packets_.GetTransmissionInfo(packet_number);
DCHECK(!transmission_info.retransmittable_frames.empty());
- return PendingRetransmission(path_id_, packet_number, transmission_type,
- transmission_info.retransmittable_frames,
- transmission_info.has_crypto_handshake,
- transmission_info.num_padding_bytes,
- transmission_info.encryption_level,
- transmission_info.packet_number_length);
+ return QuicPendingRetransmission(path_id_, packet_number, transmission_type,
+ transmission_info.retransmittable_frames,
+ transmission_info.has_crypto_handshake,
+ transmission_info.num_padding_bytes,
+ transmission_info.encryption_level,
+ transmission_info.packet_number_length);
}
QuicPacketNumber QuicSentPacketManager::GetNewestRetransmission(
QuicPacketNumber packet_number,
- const TransmissionInfo& transmission_info) const {
+ const QuicTransmissionInfo& transmission_info) const {
QuicPacketNumber retransmission = transmission_info.retransmission;
while (retransmission != 0) {
packet_number = retransmission;
@@ -508,7 +508,7 @@ void QuicSentPacketManager::MarkPacketNotRetransmittable(
return;
}
- const TransmissionInfo& transmission_info =
+ const QuicTransmissionInfo& transmission_info =
unacked_packets_.GetTransmissionInfo(packet_number);
QuicPacketNumber newest_transmission =
GetNewestRetransmission(packet_number, transmission_info);
@@ -525,7 +525,7 @@ void QuicSentPacketManager::MarkPacketNotRetransmittable(
}
void QuicSentPacketManager::MarkPacketHandled(QuicPacketNumber packet_number,
- TransmissionInfo* info,
+ QuicTransmissionInfo* info,
QuicTime::Delta ack_delay_time) {
QuicPacketNumber newest_transmission =
GetNewestRetransmission(packet_number, *info);
@@ -552,7 +552,7 @@ void QuicSentPacketManager::MarkPacketHandled(QuicPacketNumber packet_number,
// transmission of a crypto packet is in flight at once.
// TODO(ianswett): Instead of handling all crypto packets special,
// only handle nullptr encrypted packets in a special way.
- const TransmissionInfo& newest_transmission_info =
+ const QuicTransmissionInfo& newest_transmission_info =
unacked_packets_.GetTransmissionInfo(newest_transmission);
if (HasCryptoHandshake(newest_transmission_info)) {
unacked_packets_.RemoveFromInFlight(newest_transmission);
@@ -783,7 +783,7 @@ bool QuicSentPacketManager::MaybeUpdateRTT(const QuicAckFrame& ack_frame,
}
// We calculate the RTT based on the highest ACKed packet number, the lower
// packet numbers will include the ACK aggregation delay.
- const TransmissionInfo& transmission_info =
+ const QuicTransmissionInfo& transmission_info =
unacked_packets_.GetTransmissionInfo(ack_frame.largest_observed);
// Ensure the packet has a valid sent time.
if (transmission_info.sent_time == QuicTime::Zero()) {
@@ -1049,7 +1049,7 @@ size_t QuicSentPacketManager::GetConsecutiveTlpCount() const {
return consecutive_tlp_count_;
}
-TransmissionInfo* QuicSentPacketManager::GetMutableTransmissionInfo(
+QuicTransmissionInfo* QuicSentPacketManager::GetMutableTransmissionInfo(
QuicPacketNumber packet_number) {
return unacked_packets_.GetMutableTransmissionInfo(packet_number);
}
« no previous file with comments | « net/quic/core/quic_sent_packet_manager.h ('k') | net/quic/core/quic_sent_packet_manager_interface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698