Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1389)

Issue 2531163009: Move QuicAckListenerInterface, QuicPendingRetransmission, and QuicTransmissionInfo out of quic_pack… (Closed)

Created:
4 years ago by Victor Vasiliev
Modified:
4 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move QuicAckListenerInterface, QuicPendingRetransmission, and QuicTransmissionInfo out of quic_packets.{h,cc}. No behavior change. Merge internal change: 139371729 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : Move QuicAckListenerInterface, QuicPendingRetransmission, and QuicTransmissionInfo out of quic_pack… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+336 lines, -243 lines) Patch
M net/net.gypi View 3 chunks +5 lines, -0 lines 0 comments Download
A net/quic/core/quic_ack_listener_interface.h View 1 1 chunk +48 lines, -0 lines 0 comments Download
A net/quic/core/quic_ack_listener_interface.cc View 1 1 chunk +20 lines, -0 lines 0 comments Download
M net/quic/core/quic_connection.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/core/quic_multipath_sent_packet_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_multipath_sent_packet_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/quic/core/quic_multipath_sent_packet_manager_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_packet_creator.h View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/core/quic_packet_creator.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_packet_creator_test.cc View 8 chunks +12 lines, -12 lines 0 comments Download
M net/quic/core/quic_packet_generator.h View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/core/quic_packet_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_packets.h View 3 chunks +1 line, -103 lines 0 comments Download
M net/quic/core/quic_packets.cc View 3 chunks +0 lines, -45 lines 0 comments Download
A net/quic/core/quic_pending_retransmission.h View 1 1 chunk +44 lines, -0 lines 0 comments Download
M net/quic/core/quic_sent_packet_manager.h View 4 chunks +13 lines, -12 lines 0 comments Download
M net/quic/core/quic_sent_packet_manager.cc View 11 chunks +19 lines, -19 lines 0 comments Download
M net/quic/core/quic_sent_packet_manager_interface.h View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/core/quic_sent_packet_manager_test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
A net/quic/core/quic_transmission_info.h View 1 1 chunk +61 lines, -0 lines 0 comments Download
A net/quic/core/quic_transmission_info.cc View 1 1 chunk +45 lines, -0 lines 0 comments Download
M net/quic/core/quic_unacked_packet_map.h View 7 chunks +20 lines, -15 lines 0 comments Download
M net/quic/core/quic_unacked_packet_map.cc View 10 chunks +28 lines, -22 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 2 (0 generated)
Victor Vasiliev
4 years ago (2016-11-30 20:09:14 UTC) #1
Ryan Hamilton
4 years ago (2016-11-30 20:48:35 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698