Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2531163006: [crankshaft] Disable escape analysis of nested objects. (Closed)

Created:
4 years ago by Jarin
Modified:
4 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Michael Hablich, Michael Starzinger
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Disable escape analysis of nested objects. BUG=chromium:669024 Committed: https://crrev.com/e19f43df619ae9f7c8100f4b617ac458fb947fd0 Cr-Commit-Position: refs/heads/master@{#41389}

Patch Set 1 #

Patch Set 2 : Test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-669024.js View 1 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
Jarin
Could you take a look, please?
4 years ago (2016-11-30 09:48:39 UTC) #11
Benedikt Meurer
Awesome, LGTM!
4 years ago (2016-11-30 10:35:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2531163006/20001
4 years ago (2016-11-30 15:05:13 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-30 15:06:56 UTC) #17
commit-bot: I haz the power
4 years ago (2016-11-30 15:07:26 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e19f43df619ae9f7c8100f4b617ac458fb947fd0
Cr-Commit-Position: refs/heads/master@{#41389}

Powered by Google App Engine
This is Rietveld 408576698