third_party/WebKit/Source/core/frame/FrameSerializer.h - Issue 2531163004: Remove attributes that contain javascript from MHTML

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameSerializer.h

Issue 2531163004: Remove attributes that contain javascript from MHTML (Closed)

Patch Set: Address final feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameSerializer.h

diff --git a/third_party/WebKit/Source/core/frame/FrameSerializer.h b/third_party/WebKit/Source/core/frame/FrameSerializer.h

index e2e6885bd68b150614d52545edbb157c0f6f2fa9..856863fd3bbd6ee9b5008477fedd30417b4889ac 100644

--- a/third_party/WebKit/Source/core/frame/FrameSerializer.h

+++ b/third_party/WebKit/Source/core/frame/FrameSerializer.h

@@ -68,7 +68,9 @@ class CORE_EXPORT FrameSerializer final {

class Delegate {

public:

// Controls whether HTML serialization should skip the given attribute.

- virtual bool shouldIgnoreAttribute(const Attribute&) { return false; }

+ virtual bool shouldIgnoreAttribute(const Element&, const Attribute&) {

+ return false;

+ }

// Method allowing the Delegate control which URLs are written into the

// generated html document.